Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix phf::Map::get call #1
Conversation
This comment has been minimized.
This comment has been minimized.
|
This regression was found in the regression report It's also tracked in rust bug rust-lang/rust/issues/28853 This fix is a workaround that seems logical. |
This comment has been minimized.
This comment has been minimized.
|
@bluss Thanks! |
mozillazg
added a commit
that referenced
this pull request
Nov 21, 2015
mozillazg
merged commit 5ce8445
into
mozillazg:master
Nov 21, 2015
bluss
deleted the
bluss:fix-captures
branch
Nov 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bluss commentedNov 21, 2015
Fix phf::Map::get call
This fixes a regression that caused the crate to stop compiling on
current rust nightly and beta versions.
capis already a&str, so passing justcapinstead of&capisfine.