jobtype changed in jobvite feeds #25

Merged
merged 1 commit into from Feb 26, 2013

Projects

None yet

3 participants

@l-hedgehog

full-time -> employee
contractor -> seasonal

@fwenzel
fwenzel commented Feb 22, 2013

summoning @ednapiranha :) (next week)

@ednapiranha

This won't work. JavaScript reads the data-jobtype attribute to switch between types. This will break it.

@ednapiranha

Actually I checked again and your PR is correct but we are in the process of switching to a more recent version of playdoh and django. This means your current PR won't work with new layout. Either you can send a PR with the latest code base or I can add it after. Let me know - thanks!

@l-hedgehog

I guess that means I should rebase this patch onto use-playdoh-lib branch? I'd like to :-)

@l-hedgehog l-hedgehog jobtype changed in jobvite feeds
full-time -> employee
contractor -> seasonal
5913f9b
@l-hedgehog

Just noticed use-playdoh-lib is merged into master earlier.

@ednapiranha

awesome! thanks :)

@ednapiranha ednapiranha merged commit cf278fd into mozmar:master Feb 26, 2013
@l-hedgehog l-hedgehog deleted the l-hedgehog:feed-jobtype branch Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment