New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add infra tests for MDN ELBs #664

merged 2 commits into from Dec 4, 2017


None yet
2 participants

metadave commented Nov 30, 2017

here's an experiment.

This PR has some pytest code that tests stage/prod ELBs to ensure they're configured correctly, specifically:

  • is the ELB configured to use port 80, and is traffic sent to the redirector NodePort?
  • is the ELB configured to use port 443, and is traffic sent to the mdn web service NodePort?
  • are ELB listener protocols specified correctly?
  • is ELB logging enabled?
  • is the connection timeout configured to use the same value as specified in the apps/mdn/mdn-aws/k8s/Makefile?

These tests depend on values specified in the region env files located in apps/mdn/mdn-aws/k8s/regions/. I'm using os.environ without checking for empty values: if they're empty, the test should fail. Also, some boto3/k8s queries blindly access array elements, if they don't work... something is wrong with the env.

(autopep8 made my long lines ugly.)

Do NOT run this in Jenkins or any tool that will expose build logs as failure output includes security creds etc.

@metadave metadave requested review from jgmize, jwhitlock and escattone Nov 30, 2017


jgmize approved these changes Nov 30, 2017


@jgmize jgmize merged commit 446df77 into master Dec 4, 2017

@jgmize jgmize deleted the dp_test_mdn_elbs branch Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment