Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional config branches for more targeted deployments #1061

Closed
wants to merge 1 commit into from

Conversation

4 participants
@jgmize
Copy link
Member

commented Jul 3, 2019

Together with mozmeao/snippets-config#26 this gives us an automatically updated master branch while only triggering one deployment at a time.

@jgmize jgmize requested review from jpetto and glogiotatidis Jul 3, 2019

@jgmize jgmize force-pushed the update-additional-branch branch from 60082d0 to dfa17d4 Jul 3, 2019

@jgmize jgmize force-pushed the update-additional-branch branch from dfa17d4 to f5cf2a1 Jul 3, 2019

@jgmize jgmize added this to In progress (limit 12) in MozMEAO backend/infra via automation Jul 3, 2019

@glogiotatidis

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

This looks good. I want to make myself comfortable with the new ci and possibly fine tune a few more bits. If you don't mind let's hold changes for a day or two until I wrap my head around this.

@jpetto

jpetto approved these changes Jul 3, 2019

Copy link
Contributor

left a comment

This looks good to me and I'm on board with the philosophy of not having changes to master trigger every pipeline.

Small suggestion to change ADDITIONAL_BRANCH to DEPLOY_BRANCH.

Will wait on feedback from @glogiotatidis before merging.

@jpetto

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

@pmac Can you give this (and the related PR) a look over in terms of approach? I think it'd be good to get the team on board with changes from this point forward.

@glogiotatidis
Copy link
Member

left a comment

I used the only/changes gitlab-ci directive which allows targeted deployments in a cleaner way imho. https://github.com/mozmeao/snippets-config/blob/master/.gitlab-ci.yml#L27

@pmac

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Very cool Giorgos!

@jgmize

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

thanks @glogiotatidis, mozmeao/snippets-config#28 is a much better approach.

@jgmize jgmize closed this Jul 8, 2019

@glogiotatidis glogiotatidis deleted the update-additional-branch branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.