Record sent-time on command queueing #314

Closed
HaloFour opened this Issue Jul 22, 2016 · 1 comment

Projects

None yet

2 participants

@HaloFour

I'm trying to use a custom CommandLatencyCollector to record metrics regarding the execution time of commands through Lettuce. I'm finding that the completionLatency argument is invariably a very large number. Tracking through the code in Lettuce I'm finding that while WithLatency#firstResponse and WithLatency#completed are being called, WithLatency#sent never is, so the value remains the initial value of -1. The completionLatency argument is calculated from WithLatency#getCompleted - WithLatency#getSent.

@mp911de mp911de added the bug label Jul 24, 2016
@mp911de mp911de added this to the Lettuce 4.2.2 milestone Jul 24, 2016
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de Record sent-time on queueing #314
WithLatency.sent(long) is now called in queueCommand.
9051914
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de Record sent-time on queueing #314
WithLatency.sent(long) is now called in queueCommand.
2cbda80
@mp911de
Owner
mp911de commented Jul 24, 2016

Thanks, that's fixed now.

@mp911de mp911de closed this Jul 24, 2016
@mp911de mp911de changed the title from Metrics: WithLatency.sent(long) never called to Record sent-time on command queueing Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment