CommandHandler notifications called out of order #315

Closed
mp911de opened this Issue Jul 23, 2016 · 1 comment

Projects

None yet

1 participant

@mp911de
Owner
mp911de commented Jul 23, 2016

In some cases, event notifications for reconnection CommandHandler are called out-of-order.

Adding a command handler id makes visible what's going on:

  1. The channel is deactivated
  2. The channel is reconnected
  3. The channel receives an activation
  4. The channel is unregistered (notification from the previous channel I/O)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-1] [CommandHandlerId 0x31e, /127.0.0.1:36367 -> localhost/127.0.0.1:6479] deactivating channel handler (CommandHandler:708)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-2] [CommandHandlerId 0x31e, (inactive)] channelRegistered() (CommandHandler:113)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-2] [CommandHandlerId 0x31e, /127.0.0.1:36371 -> localhost/127.0.0.1:6479] channelActive() (CommandHandler:583)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-1] [CommandHandlerId 0x31e, /127.0.0.1:36371 -> localhost/127.0.0.1:6479] channelInactive() done (CommandHandler:733)
2016-07-23 20:58:54 [DEBUG] [lettuce-nioEventLoop-6-1] [CommandHandlerId 0x31e, /127.0.0.1:36371 -> localhost/127.0.0.1:6479] channelUnregistered()
@mp911de mp911de added the bug label Jul 23, 2016
@mp911de mp911de added this to the Lettuce 4.2.2 milestone Jul 23, 2016
@mp911de mp911de added a commit that referenced this issue Jul 23, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
a7e2818
@mp911de mp911de added a commit that referenced this issue Jul 23, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
f912930
@mp911de mp911de added a commit that referenced this issue Jul 23, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
f25ebb3
@mp911de mp911de added a commit that referenced this issue Jul 23, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
3f87fa9
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
4e60aba
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
cc9a259
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
38b46e5
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
e6581f4
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
6bc60bf
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
dff81cc
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
f11d323
@mp911de mp911de added a commit that referenced this issue Jul 24, 2016
@mp911de CommandHandler notifications called out of order #315
Discard out-of-order events for disconnected/reconnected connections if inactive/unregister events arrive after register/active events of a reconnect. Allocate temporary buffer upon channel-handler initialization and do not remove the buffer until the channel is closed.
dcd0532
@mp911de
Owner
mp911de commented Jul 24, 2016

Fixed.

@mp911de mp911de closed this Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment