MasterSlaveTopologyProvider does not recognize slave if slave ip uses IPv6 address #329

Closed
maksimlikharev opened this Issue Aug 7, 2016 · 1 comment

Projects

None yet

2 participants

@maksimlikharev
maksimlikharev commented Aug 7, 2016 edited

windows port of redis, lettuce 4.2.1.Final.

2 redis running on the same box, one master another slave, windows, this is my sandbox

StatefulRedisMasterSlaveConnection<String, String> connection = MasterSlave.connect(client,
   new Utf8StringCodec(),
   RedisURI.builder().redis(config.getHost(), config.getPort()).build());

host and port points to master

replication info returned as

Replication

role:master
connected_slaves:1
slave0:ip=::20f8:1400:0:0,port=6380,state=online,offset=12132,lag=1
master_repl_offset:12132
repl_backlog_active:1
repl_backlog_size:1048576
repl_backlog_first_byte_offset:2
repl_backlog_histlen:12131

slave not recognized

@mp911de mp911de added this to the Lettuce 4.2.2 milestone Aug 10, 2016
@mp911de mp911de added the bug label Aug 11, 2016
@mp911de mp911de changed the title from Slave not recognized if slave ip returned as ipv6 for MasterSlaveTopologyProvider.java to MasterSlaveTopologyProvider does not recognize slave if slave ip uses IPv6 address Aug 11, 2016
@mp911de mp911de added a commit that referenced this issue Aug 11, 2016
@mp911de Fix master and slave address parsing for IPv6 addresses #329
MasterSlaveTopologyProvider now parses IPv6 addresses correctly so master and slave nodes are no longer removed from the node list.
12a0b13
@mp911de
Owner
mp911de commented Aug 11, 2016

Thanks for the bug report. That's fixed now.

@mp911de mp911de closed this Aug 11, 2016
@mp911de mp911de added a commit that referenced this issue Aug 11, 2016
@mp911de Fix master and slave address parsing for IPv6 addresses #329
MasterSlaveTopologyProvider now parses IPv6 addresses correctly so master and slave nodes are no longer removed from the node list.
a5885f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment