Errors during command completion swallows queued commands #331

Closed
mp911de opened this Issue Aug 10, 2016 · 0 comments

Projects

None yet

1 participant

@mp911de
Owner
mp911de commented Aug 10, 2016

Exceptions during command completion are propagated to the generic exception handler (exceptionCaught). The exception handler inspects whether the queue is empty and if not, the next command is pulled from the queue and completed with the exception.

In the specific case of #323 the causing command is already pulled from the queue so the next command in the queue receives the exception and the connection is out of sync.

@mp911de mp911de added the bug label Aug 10, 2016
@mp911de mp911de added this to the Lettuce 4.2.2 milestone Aug 10, 2016
@mp911de mp911de added a commit that referenced this issue Aug 10, 2016
@mp911de Guard command completion against exceptions #331
Command completion is now guarded by try/catch to prevent the global exception handler to kick in. Commands must be removed from the queue prior to completion to prevent duplicate submission on ping-before-reconnect.

See also #323
724b9da
@mp911de mp911de added a commit that referenced this issue Aug 10, 2016
@mp911de Guard command completion against exceptions #331
Command completion is now guarded by try/catch to prevent the global exception handler to kick in. Commands must be removed from the queue prior to completion to prevent duplicate submission on ping-before-reconnect.

See also #323
9d3bba7
@mp911de mp911de closed this Aug 10, 2016
@mp911de mp911de added a commit that referenced this issue Aug 18, 2016
@mp911de Polishing #331
Move exception handling for failed command completion into ReactiveCommandDispatcher as that's the motivation for #331. Log exception in command handler on exceptions during command completion.
1d91b7f
@mp911de mp911de added a commit that referenced this issue Aug 18, 2016
@mp911de Polishing #331
Move exception handling for failed command completion into ReactiveCommandDispatcher as that's the motivation for #331. Log exception in command handler on exceptions during command completion.
4bc0f1e
@mp911de mp911de added a commit that referenced this issue Aug 19, 2016
@mp911de Polishing #331
Move exception handling for failed command completion into ReactiveCommandDispatcher as that's the motivation for #331. Log exception in command handler on exceptions during command completion.
a3ac63c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment