mget with Iterable within redis cluster not working #303

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@agodet
agodet commented Jul 5, 2016

If you try to use mget on a redis cluster, two methods are defined, the first with varargs and the other with a Collection of keys. The second one is not override by the RedisAdvancedClusterAsyncCommandsImpl, then if you try to use it you will have an error : "ERR CROSSSLOT Keys in request don't hash to the same slot"

Godet Alexandre mget with Iterable within redis cluster not working
b1f4eea
@coveralls
coveralls commented Jul 5, 2016 edited

Coverage Status

Coverage increased (+0.1%) to 93.289% when pulling b1f4eea on agodet:master into 1727b06 on mp911de:master.

@mp911de
Owner
mp911de commented Jul 7, 2016

Thanks for your PR. The intention of the API interfaces it to not use the concrete implementation classes (use RedisAdvancedClusterAsyncCommands instead of RedisAdvancedClusterAsyncCommandsImpl).

@mp911de mp911de added the enhancement label Jul 7, 2016
@mp911de mp911de added a commit that referenced this pull request Jul 7, 2016
@mp911de Godet Alexandre + Allow coordinated cross-slot execution using Iterable #303
mget, del and unlink provide methods with var-args signatures and declare signatures accepting Iterable. Only methods accepting varargs allow coordinated cross-slot execution. The other methods accepting Iterable fail because cross-slot keys are sent directly to Redis and not coordinated amongst Redis Cluster nodes.
88e7051
@mp911de mp911de added a commit that referenced this pull request Jul 7, 2016
@mp911de Polishing #303 926b877
@mp911de mp911de added a commit that referenced this pull request Jul 7, 2016
@mp911de Godet Alexandre + Allow coordinated cross-slot execution using Iterable #303
mget, del and unlink provide methods with var-args signatures and declare signatures accepting Iterable. Only methods accepting varargs allow coordinated cross-slot execution. The other methods accepting Iterable fail because cross-slot keys are sent directly to Redis and not coordinated amongst Redis Cluster nodes.
9ab972c
@mp911de mp911de added a commit that referenced this pull request Jul 7, 2016
@mp911de Polishing #303 c4da1d4
@mp911de
Owner
mp911de commented Jul 7, 2016

Thanks a lot. That's merged with 9ab972c. I also added overrides for the other var-args methods.

@mp911de mp911de closed this Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment