Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

update deprecated function ( avcodec_alloc_frame, get_buffer, avcodec_default_get_buffer ) #19

Merged
merged 1 commit into from Feb 13, 2014

Conversation

Projects
None yet
3 participants
Contributor

Schebb commented Jan 21, 2014

avcodec_alloc_frame -> av_frame_alloc
avcodec_default_get_buffer -> avcodec_default_get_buffer2
get_buffer -> get_buffer2

... and clean space at end of line.

need also to update:

  • avcodec_default_release_buffer
  • release_buffer
Owner

mpenkov commented Feb 13, 2014

Hey, thanks for doing the update. I notice there's a lot of unnecessary white space changes mixed in the same commit with good changes; can you please modify the commit to remove them? I don't mind you changing the whitespace, I just think they belong in a separate commit, to keep things easy to understand.

Contributor

Schebb commented Feb 13, 2014

Done.

Actually, I noticed the whitespace changes after the commit (wrong emacs config :-/). I only changed the functions on this commit.

Collaborator

chelyaev commented Feb 13, 2014

Actually, it's probably better not to change any whitespace at all. That way, people can diff the most recent version of the source with the old Dranger tutorials and still get a meaningful result.

chelyaev added a commit that referenced this pull request Feb 13, 2014

Merge pull request #19 from Schebb/master
update deprecated function ( avcodec_alloc_frame, get_buffer, avcodec_default_get_buffer )

@chelyaev chelyaev merged commit 172ec32 into mpenkov:master Feb 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment