shutdown waits for all work to finish processing instead of just waiting for the queue to be drained before returning #55

Merged
merged 3 commits into from Jul 16, 2012

Projects

None yet

3 participants

@joenoon
Contributor
joenoon commented Jul 15, 2012

No description provided.

joenoon added some commits Jul 15, 2012
@joenoon joenoon shutdown waits for all work to finish processing instead of just wait…
…ing for the

queue to be drained before returning
5e958b1
@joenoon joenoon handle shutting down state more gracefully. was previously waiting
for the queue to drain, now lets work fully complete, but lets new work
sit in the persister
792c93c
@joenoon joenoon checking @busy_workers.size is sufficient, and the other check was no…
…t correct
4a468dc
@xaviershay
Collaborator

Read through the commits, looks pretty good to me. I'll let it sit here for a day or two in case others want to comment.

@mperham mperham merged commit 5f24164 into mperham:master Jul 16, 2012
@mperham
Owner
mperham commented Jul 16, 2012

Thanks Joe. Don't forget to update the changelog in the future.

@joenoon
Contributor
joenoon commented Jul 16, 2012

Great, will do next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment