Permalink
Browse files

verbage

  • Loading branch information...
mperham committed Feb 26, 2014
1 parent f39be47 commit 30da69dcbdde52a8bf515dccee061d19d2e05432
Showing with 8 additions and 3 deletions.
  1. +1 −1 Changes.md
  2. +7 −2 Upgrading.md
View
@@ -3,7 +3,7 @@
Please see [Upgrading.md](Upgrading.md) for more comprehensive upgrade notes.
-- **Global Error Handlers** - blocks of code which process errors which
+- **Global Error Handlers** - blocks of code which handle errors that
occur anywhere within Sidekiq, not just within middleware.
- **Dead Job Queue** - jobs which run out of retries are now moved to a dead
job queue. These jobs must be retried manually or they will expire
View
@@ -21,7 +21,7 @@ changes a few data elements in Redis. To upgrade cleanly:
* Ruby 1.9 is no longer officially supported. Sidekiq's official
support policy is to support the current and previous major releases
of Ruby and Rails. As of February 2014, that's Ruby 2.1, Ruby 2.0, Rails 4.0
- and Rails 3.2. I will accept PRs to fix issues found by users.
+ and Rails 3.2. I will consider PRs to fix issues found by users.
## Error Service Providers
@@ -33,9 +33,14 @@ just during job execution.
```ruby
if Sidekiq::VERSION < '3'
# old behavior
+ Sidekiq.configure_server do |config|
+ config.server_middleware do |chain|
+ chain.add MyErrorService::Middleware
+ end
+ end
else
Sidekiq.configure_server do |config|
- config.error_handlers << Proc.new {|ex,context| ... }
+ config.error_handlers << Proc.new {|ex,context| MyErrorService.notify(ex, context) }
end
end
```

0 comments on commit 30da69d

Please sign in to comment.