Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic Redis connection naming #4479

Closed
mperham opened this issue Mar 6, 2020 · 2 comments
Closed

Remove automatic Redis connection naming #4479

mperham opened this issue Mar 6, 2020 · 2 comments

Comments

@mperham
Copy link
Owner

@mperham mperham commented Mar 6, 2020

Unfortunately this feature is often disabled by SaaSes and so Sidekiq users have to manually disable it. I don't believe it adds much value; I've never heard of anyone using it as intended for debugging purposes so let's remove it.

https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/redis_connection.rb#L15

@Tolsto
Copy link

@Tolsto Tolsto commented Jul 7, 2020

We actually did use it :(
Would you consider re-adding it to Sidekiq(-Pro) as a configurable option?

@mperham
Copy link
Owner Author

@mperham mperham commented Jul 7, 2020

You can add it yourself, just add an :id key to the redis hash in your initializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.