Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis::Namespace#exists? doesn't work #4636

Closed
alpaca-tc opened this issue Jul 9, 2020 · 1 comment
Closed

Redis::Namespace#exists? doesn't work #4636

alpaca-tc opened this issue Jul 9, 2020 · 1 comment

Comments

@alpaca-tc
Copy link

Ruby version:2.7.1p83
Sidekiq / Pro / Enterprise version(s): sidekiq-pro 5.1.1

Please include your initializer and any error message with the full backtrace.

Are you using an old version?
Have you checked the changelogs to see if your issue has been fixed in a later version?

https://github.com/mperham/sidekiq/blob/master/Changes.md
https://github.com/mperham/sidekiq/blob/master/Pro-Changes.md
https://github.com/mperham/sidekiq/blob/master/Ent-Changes.md


RuntimeError: Did not find our own heartbeat within 10 seconds, that's bad (Most recent call first)

File /usr/local/bundle/gems/sidekiq-pro-5.1.1/lib/sidekiq/pro/super_fetch.rb line 229 in wait_for_heartbeat
File /usr/local/bundle/gems/sidekiq-pro-5.1.1/lib/sidekiq/pro/super_fetch.rb line 59 in block in startup
File /usr/local/bundle/gems/sidekiq-6.1.0/lib/sidekiq/util.rb line 15 in watchdog
File /usr/local/bundle/gems/sidekiq-pro-5.1.1/lib/sidekiq/pro/super_fetch.rb line 54 in startup
File /usr/local/bundle/gems/sidekiq-pro-5.1.1/lib/sidekiq/pro/super_fetch.rb line 43 in block (2 levels) in setup

Redis::Namespace doesn't support #exists?

redis.exists? doesn't work if sidekiq used Redis::Namespace as redis client. see details

Sorry, I didn't know how to send a PR to sidekiq-pro 😢
Please replace exists? with exists :) or let me know how to send PR to sidekiq-pro.

lib/sidekiq/pro/super_fetch.rb:191
lib/sidekiq/pro/super_fetch.rb:224
@alpaca-tc alpaca-tc changed the title Redis::Namespace#exists? is deprecated Redis::Namespace#exists? doesn't work Jul 9, 2020
@alpaca-tc
Copy link
Author

Fixed this problem resque/redis-namespace#171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant