Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Testing sidekiq at Sidekiq::Client level #713

Closed
NielsKSchjoedt opened this Issue Feb 18, 2013 · 3 comments

Comments

3 participants

Is it just me, or wouldn't it be better to have this https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/testing.rb implemented at the Sidekiq::Client level instead https://github.com/mperham/sidekiq/blob/master/lib/sidekiq/client.rb ?

Think about the situation where you call Sidekiq::Client.push in your code - or just use the resque compatibility helpers...

Owner

mperham commented Feb 18, 2013

Yeah, we should probably just have testing helpers which override Sidekiq::Client.raw_push. The Client impl has been refactored over the last year - it wasn't totally stable - so this is possible now. Probably something for Sidekiq 3.0 since I'm sure it will break some people's testing code.

Contributor

jdanielnd commented Feb 28, 2013

@NielsKSchjoedt did you write some code in this direction? I'm having problems to retrieve :jid from client_push method override by sidekiq/testing. It always returns true.

No sorry, I didn't :-(

@mperham mperham closed this in 07a2781 Mar 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment