Sidekiq 3.0 changes #1519

Merged
merged 31 commits into from Mar 1, 2014

4 participants

@mperham
Owner

See Upgrading.md and Changes.md for detailed notes.

@mperham mperham merged commit fae2913 into master Mar 1, 2014

1 check passed

Details default The Travis CI build passed
@mperham
Owner

BOOM!

@mperham mperham deleted the 3-0 branch Mar 1, 2014
@jonhyman
Collaborator
@nik

am i crazy? , it seems like there's an extra ENV

+ ENV[ENV['REDIS_PROVIDER'] || 'REDIS_URL']
this will take the value of REDIS_PROVIDER and if it's not nil use that value to index ENV again...thus pretty much always returning nil... which would force someone to always use REDIS_URL

Collaborator

Not crazy , just confused.

value = ENV['REDIS_PROVIDER'] || 'REDIS_URL'
 ENV[value]

In short you can set ENV['REDIS_PROVIDER'] to tell sidekiq which ENV value to search for the REDIS_URL , by default it will search for it in ENV['REDIS_URL']

thanks. totally misunderstood the nature of this

Not inside of the redis_connection file. Probably could have looked at the tests though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment