Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing duplicated code #1702

Merged
merged 2 commits into from May 13, 2014
Merged

removing duplicated code #1702

merged 2 commits into from May 13, 2014

Conversation

@lucianosousa
Copy link
Contributor

@lucianosousa lucianosousa commented May 13, 2014

just a small refactoring

@@ -87,11 +87,7 @@ def custom_tabs
params['key'].each do |key|
job = Sidekiq::DeadSet.new.fetch(*parse_params(key)).first
next unless job

This comment has been minimized.

@mperham

mperham May 13, 2014
Owner

Every block you changed needs to check for nil job. How about standardizing that check?

This comment has been minimized.

@mperham

mperham May 13, 2014
Owner

i.e. I like your xxx if job better than my next unless job

@lucianosousa
Copy link
Contributor Author

@lucianosousa lucianosousa commented May 13, 2014

@mperham done!

mperham added a commit that referenced this pull request May 13, 2014
@mperham mperham merged commit 4731272 into mperham:master May 13, 2014
1 check failed
1 check failed
@mperham
continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants