Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Migrate Sidekiq::Web to a pure Rack application #3069
Migrate Sidekiq::Web to a pure Rack application to avoid sinatra as
The application is mounted on top of Rack::Builder, mantaining all of
Rack apps being used:
Sidekiq::WebApplication is a very simple rack application composed of a
The Router is heavily inspired on Rack::Router(and in many parts
The Action is a wrapper to provide convenience, DRY code and maintain
I tried to mantain most of the old application structure so that
This is a huge change so a couple of notes:
Looks like the test suite is passing so that's a huge step forward.
Hi Mike, thank you very much for the kind words.
There are 3 important things to consider as well:
That said: the ERB templates should be cached and the configuration flexibility is still lacking. I just pulled this in an all-nighter so I'll take a look at these refinements later on.
Sinatra's hooks for registering extensions are used by Sidekiq Pro, Sidekiq Enterprise and a lot of 3rd party extensions. We'll need to add support for them. I can help but that appears to be the biggest blocker right now.
@mperham I've made some improvements and the sidetiq page is already accessible. Some points though:
We will have to decide what to deprecate and what not, fortunately it looks pretty straightforward to upgrade old extensions to the new model.