New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue size to web show page #3896

Merged
merged 3 commits into from Aug 13, 2018

Conversation

4 participants
@spk
Contributor

spk commented Jul 24, 2018

1533933847

@mperham

This comment has been minimized.

Owner

mperham commented Aug 3, 2018

I don't like the look of it in the page title. Maybe there's a better design but I'm not a designer so I can't offer an alternative.

@thegorgon

This comment has been minimized.

Contributor

thegorgon commented Aug 5, 2018

Sorry to pile on, but what if it was like a badge? e.g bootstrap or materialize

@spk

This comment has been minimized.

Contributor

spk commented Aug 10, 2018

i've updated the PR and screenshot based on @thegorgon suggestion

@mperham

This comment has been minimized.

Owner

mperham commented Aug 10, 2018

Nice, much better. @queue.size will make a network roundtrip to Redis and be out of sync with the queue pages. Use @total_size instead which suffers from neither problem.

@bobber205

This comment has been minimized.

bobber205 commented Aug 13, 2018

I love this change!

@mperham mperham merged commit 6e18326 into mperham:master Aug 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@spk

This comment has been minimized.

Contributor

spk commented Aug 14, 2018

Thanks @mperham for the fix, cheers

@spk spk deleted the spk:add-size-to-queue-web-page branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment