Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence Ruby 2.7 warnings #4412

Merged
merged 1 commit into from Dec 31, 2019
Merged

Silence Ruby 2.7 warnings #4412

merged 1 commit into from Dec 31, 2019

Conversation

@kddeisz
Copy link
Contributor

kddeisz commented Dec 31, 2019

Since you can pass kwargs to Logger.new, you need to explicitly handle them in the subclass otherwise you get a warning.

Since you can pass kwargs to Logger.new, you need to explicitly handle them in the subclass otherwise you get a warning.
@mperham mperham merged commit cc1a37d into mperham:master Dec 31, 2019
@mperham

This comment has been minimized.

Copy link
Owner

mperham commented Dec 31, 2019

🎵 Livin' on the edge! 🎶

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.