Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bump the version of multi_json that Sidekiq is dependent on. #559

Merged
merged 1 commit into from

3 participants

@brandonhilkert
Collaborator

No description provided.

@mperham mperham merged commit 0fd7e97 into from
@nateberkopec

Unfortunately, it looks like this is incompatible with Rails 3.1.x.

Bundler could not find compatible versions for gem "multi_json":
  In Gemfile:
    sidekiq (>= 0) ruby depends on
      multi_json (>= 1.3.0) ruby

    rails (= 3.1.8) ruby depends on
      multi_json (1.2.0)

https://github.com/rails/rails/blob/3-1-stable/activesupport/activesupport.gemspec#L21

@mperham
Owner

I was afraid of that. @brandonhilkert Can you revert?

@mperham
Owner

Once Rails 4 is out, we'll release a new major version of Sidekiq that only supports 4 and 3.2. Until then, 3.1 needs to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  sidekiq.gemspec
View
2  sidekiq.gemspec
@@ -18,7 +18,7 @@ Gem::Specification.new do |gem|
gem.add_dependency 'redis-namespace'
gem.add_dependency 'connection_pool', '~> 0.9.2'
gem.add_dependency 'celluloid', '~> 0.12.0'
- gem.add_dependency 'multi_json', '~> 1'
+ gem.add_dependency 'multi_json', '>= 1.3.0'
gem.add_development_dependency 'minitest', '~> 4'
gem.add_development_dependency 'sinatra'
gem.add_development_dependency 'slim'
Something went wrong with that request. Please try again.