Permalink
Browse files

adding LogLevel configuration directive

  • Loading branch information...
1 parent 3241bd4 commit 7a7f36304c5d1e9a5f308db2aa1cd9a98b1dc146 @mpeters committed Dec 12, 2009
Showing with 12 additions and 5 deletions.
  1. +3 −2 Changes
  2. +0 −1 hackathon_todo.txt
  3. +7 −0 lib/Smolder/Conf.pm
  4. +2 −2 lib/Smolder/Control.pm
View
@@ -1,8 +1,8 @@
Revision history for Smolder
1.50
- + Adding bin/smolderctl - J. Swartz
- + Adding configuration directives TruncateTestFilenames, ReportsPerPage, AutoRefreshReports - J. Swartz
+ + Added bin/smolderctl - J. Swartz
+ + Added configuration directives TruncateTestFilenames, ReportsPerPage, AutoRefreshReports - J. Swartz
+ smolder now exits if any options are invalid, instead of continuing on. - A. Lester
+ Documentation improvements - M. Stosberg
+ Now storing results per-stream - J. Swartz
@@ -12,6 +12,7 @@ Revision history for Smolder
+ Fixed RT #49107 by trying to pick a better default hostname - M. Peters
+ Fixed RT #49993 by making smolder_smoke_signal default to 8080 just like Smolder does - M. Peters
+ Fixed RT #49997 by making sure we don't send duplicate emails if multiple accounts use the same address - M. Peters
+ + Added LogLevel configuration directive - M. Peters
1.40
+ Tests that died prematurely didn't mark the whole suite as failed - M. Peters
View
@@ -2,7 +2,6 @@ Easy
========
2) Move inline CSS to style sheets
4) Add good documentation for configuration
-16) Add "LogLevel" smolder.conf directive
Medium
========
View
@@ -34,6 +34,7 @@ BEGIN {
FromAddress => "smolder\@$default_hostname",
SMTPHost => $default_hostname,
LogFile => '',
+ LogLevel => 'warning',
PidFile => catdir($share_dir, 'data', 'smolder.pid'),
TemplateDir => catdir($share_dir, 'templates'),
DataDir => catdir(File::HomeDir->my_data, '.smolder'),
@@ -115,6 +116,12 @@ Log file to write to.
Default: none
+=head2 LogLevel
+
+The level at which things will start to be logged. Only used if LogFile is set.
+
+Default: warning
+
=head2 PidFile
File in which to write the PID of the Smolder process.
View
@@ -13,7 +13,7 @@ use CGI::Cookie;
# BEGIN { $ENV{CGI_APP_DEBUG} = 1 ; } use CGI::Application::Plugin::DebugScreen;
use Smolder;
use Smolder::Util;
-use Smolder::Conf qw(ErrorsToScreen HostName LogFile TemplateDir);
+use Smolder::Conf qw(ErrorsToScreen HostName LogFile LogLevel TemplateDir);
use Smolder::DB::Developer;
use Smolder::DB::Project;
use File::Spec::Functions qw(catdir catfile tmpdir);
@@ -50,7 +50,7 @@ __PACKAGE__->add_callback(
module => 'Log::Dispatch::File',
name => 'smolder_log',
mode => 'append',
- min_level => 'debug',
+ min_level => LogLevel,
filename => LogFile,
}
],

0 comments on commit 7a7f363

Please sign in to comment.