Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upavoid loading invisible files for partial panos of any image type #562
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks! This looks good. I removed the ES6 syntax to maintain backward compatibility and merged it. |
This comment has been minimized.
This comment has been minimized.
Thank you too!
This was swift :)
--
This message was sent using my Vernee Apollo Lite with K-9 Mail. Please excuse my brevity.
…On March 4, 2018 3:06:19 AM GMT+01:00, Matthew Petroff ***@***.***> wrote:
Thanks! This looks good. I removed the ES6 syntax to maintain backward
compatibility and merged it.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#562 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DDvO commentedMar 3, 2018
This is the first of a series of contributions that I plan to do over the next days or weeks,
providing various extensions/improvements of the code that I've done for myself so far,
supporting partial cylindrical panoramas like this one.
This PR extends the support for partial panoramas of any image type.
It avoids loading image/tile files that would represent just background (i.e., invisible areas),
which helps saving storage and transfer bandwidth for files that anyway would not be shown.