Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid loading invisible files for partial panos of any image type #562

Merged
merged 2 commits into from Mar 4, 2018

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Mar 3, 2018

This is the first of a series of contributions that I plan to do over the next days or weeks,
providing various extensions/improvements of the code that I've done for myself so far,
supporting partial cylindrical panoramas like this one.

This PR extends the support for partial panoramas of any image type.
It avoids loading image/tile files that would represent just background (i.e., invisible areas),
which helps saving storage and transfer bandwidth for files that anyway would not be shown.

@mpetroff mpetroff merged commit 034d27a into mpetroff:master Mar 4, 2018
@mpetroff
Copy link
Owner

@mpetroff mpetroff commented Mar 4, 2018

Thanks! This looks good. I removed the ES6 syntax to maintain backward compatibility and merged it.

@DDvO
Copy link
Contributor Author

@DDvO DDvO commented Mar 4, 2018

@DDvO DDvO deleted the partial_panos_invisible_tiles branch Mar 4, 2018
NiHoel pushed a commit to NiHoel/pannellum that referenced this issue Jun 15, 2020
…etroff#562)

Avoid loading invisible files for partial panos of any image type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants