Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMerge into master #48
Comments
This comment has been minimized.
This comment has been minimized.
|
Can we assign people to each of these subtasks? Feel free to assign me to whatever you think I am best suited for. |
This comment has been minimized.
This comment has been minimized.
|
I will take on the HaRe tests, and getting haskell-lsp prepared for release. |
This comment has been minimized.
This comment has been minimized.
I can take a look at this @fendor |
This comment has been minimized.
This comment has been minimized.
|
An issue that's affecting my particular setup (I wouldn't let this block the release though) is that for cabal projects with with-compiler set to a different compiler than the |
This comment has been minimized.
This comment has been minimized.
|
The ghc on the path is in my opinion an orthogonal problem to cradle selection. This can ultimately only be solved in |
This comment has been minimized.
This comment has been minimized.
|
I'm not sure if catching ghc exceptions would fix #32 cause i still dont know why hie doesnt respond within the |
This comment has been minimized.
This comment has been minimized.
For check that we could create a explicit |
This comment has been minimized.
This comment has been minimized.
|
Building the branch is failing for me with stack due to
Fixed with #53 |
This comment has been minimized.
This comment has been minimized.
I meant more manual testing. The ci is actively using only stack cradles, e.g. |
This comment has been minimized.
This comment has been minimized.
I've tested in a simple project:
|
This comment has been minimized.
This comment has been minimized.
|
Not sure if it worths open an issue but hie doesnt create/use |
This comment has been minimized.
This comment has been minimized.
|
@jneira for the vscode extension I changed it to go the output window by default when no log file is set, since I thought it was a bit confusing to have logs going to two separate places! |
This comment has been minimized.
This comment has been minimized.
|
Oh, ok, agree it is better, but the output of the two previous sources are being merged in the same output window now? |
This comment has been minimized.
This comment has been minimized.
|
@jneira Yeah. Previously just the logm/debugm calls from hs-logger got sent to the log file. So now it’s all those calls, plus stderr and any child process stderr |
This comment has been minimized.
This comment has been minimized.
|
I've run the test suite in my windows 10 with
Some of them are the same than the reported ones here |
This comment has been minimized.
This comment has been minimized.
|
#71 would fix the |
This comment has been minimized.
This comment has been minimized.
|
I am beginning to wonder whether we should not remove HaRe from hie until after the hie-bios merge, and whatever we do with ghcide. We do not currently have a good story for getting the project level module graph, and this means HaRe cannot work effectively. It has also been languishing for a long time waiting for underlying support, so I am not all that confident of its actual usefulness at the moment. Thoughts? |
This comment has been minimized.
This comment has been minimized.
|
Which features would be disabled by it?
|
This comment has been minimized.
This comment has been minimized.
|
I am just starting to take a look at that, as a fork off mpickering/hie-bios |
This comment has been minimized.
This comment has been minimized.
|
I have now released |
This comment has been minimized.
This comment has been minimized.
|
We made it into master! |
This issue tracks the progress to finally merge
hie-biosinto https://github.com/haskell/haskell-ide-engine.It consists of all issues that need to be worked on or PRs that need to be merged before we are ready to merge. People may be assigned to the issues. These assignments are naturally non obligatory ;D. Also, work-stealing is promoted if you run out of tasks!
hie-biosafter a release: mpickering/hie-bios#88(@mpickering, supported by @fendor)haskell-lspafter release to 0.18: alanz/haskell-lsp#201 (@alanz and @bubba)haskell-lspto 0.19 (@fendor)cabal-helperto latest (@bubba)haskell-lsp-0.18has been release (@mpickering)lintCmd: no access to the persisted file.#36 (comment) (@fendor, closed by #51)[ ] Error in vscode: "not our problem, possible fix in haskell/cabal#6441gcc.exe' failed in phaseC pre-processor'. (Exit code: 1)" #47[ ] No Hover Responses on stack project #32@fendor(not crucial for merge)[ ] Case-split command has been removed: https://github.com/mpickering/haskell-ide-engine/blob/hie-bios/src/Haskell/Ide/Engine/Plugin/HaRe.hs#L315 reimplement it! (not crucial for merge)Will be done after merge.This list is meant to be thourogh and complete. If something is missing, we will expand this list. It may look frightening but almost each of these issues is minor. We are almost done!🐳
@bubba, @alanz, @mpickering, @jneira, @power-fungus, @lorenzo