Fixing scope issue and correcting date/time#4
Merged
mplacona merged 1 commit intomplacona:masterfrom Nov 13, 2017
Merged
Conversation
Issue running this on newer version of ColdFusion (2016 and probably 11) due to scoping issue. * Fixed using `local` scope. Modified date/time fields to include date and time not just date. Also fixed the GMT fields so they are correctly calculated as well.
dcepler
changed the title
local scope issue and correcting date/time
Owner
|
I haven't looked at this project for many many years now, so glad it still kinda works. Thanks for the PR! |
Contributor
Author
|
You're welcome for the PR. Thanks for building it. Saved me quite a bit of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue running this on newer version of ColdFusion (2016 and probably 11) due to scoping issue which was fixed my explicitly using
local.Modified date/time fields to include date and time not just date. Also fixed the GMT fields so they are correctly calculated as well.