Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and streamline package for common use case #28

Merged
merged 7 commits into from Jun 18, 2019

Conversation

Projects
None yet
2 participants
@jasonmccreary
Copy link
Collaborator

commented Jun 18, 2019

Several changes in this, hope you don't mind. Mainly, set the minimum requirement of Laravel 5.5. This allowed removal of PHP < 7 syntax, old references and helpers, and deprecated Symfony methods.

Also did a general scouting of the code which lead to removal of not-so-often used options to help focus the commands purpose.

Finally a rename to provide symmetry with generate commands offered in other packages.

@jasonmccreary

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 18, 2019

Know there is a lot here. If you're not interested in maintaining this package anymore I can just use my fork or glad to take over as I have some additional ideas for changes.

@mpociot mpociot merged commit 6c706fe into mpociot:master Jun 18, 2019

@mpociot

This comment has been minimized.

Copy link
Owner

commented Jun 18, 2019

Oh wow...awesome, thanks for looking into the package in the first place. This is one of the very first packages I have ever written for Laravel (you can tell by it not having any tests).

I'm glad that you gave it some love :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.