Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for high and low tax types #49

Merged
merged 2 commits into from Jun 12, 2018
Merged

Added functionality for high and low tax types #49

merged 2 commits into from Jun 12, 2018

Conversation

SebastiaanKloos
Copy link

@SebastiaanKloos SebastiaanKloos commented May 4, 2017

In the Netherlands we have more than one tax rate.

High: 21% and Low: 6%.

https://www.belastingdienst.nl/wps/wcm/connect/bldcontentnl/belastingdienst/zakelijk/internationaal/btw_voor_buitenlandse_ondernemers/btw_berekenen/btw_tarieven/

I've added this functionality to this repository to help Dutch users.

@mpociot
Copy link
Collaborator

mpociot commented May 4, 2017

Thank you! Can you add a test for this too?

@codecov-io
Copy link

codecov-io commented May 4, 2017

Codecov Report

Merging #49 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   94.66%   94.71%   +0.05%     
==========================================
  Files           5        5              
  Lines         206      208       +2     
==========================================
+ Hits          195      197       +2     
  Misses         11       11
Impacted Files Coverage Δ
src/Mpociot/VatCalculator/VatCalculator.php 93.23% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86776da...5e688a7. Read the comment docs.

@SebastiaanKloos
Copy link
Author

@mpociot I'll try to add a test to it!

@SebastiaanKloos
Copy link
Author

SebastiaanKloos commented May 6, 2017

I've added some tests. @mpociot

@SebastiaanKloos
Copy link
Author

@mpociot Can you please review my code and merge if accepted?

@mxmtsk
Copy link

mxmtsk commented Dec 26, 2017

I was just about to open an issue for this. Any updates on when this will be merged? Germany also has two tax types, 19% and 7%

@SebastiaanKloos
Copy link
Author

@mxmtsk no response yet from moderators

@mxmtsk
Copy link

mxmtsk commented Jan 7, 2018

@mpociot Any thoughts on this, it's been a while? :)
@SebastiaanKloos would you consider adding another checkin to make it more complete and reflect Germany also?

            'rate'   => 0.19,
            'rates' => [
                'high' => 0.19,
                'low' => 0.07,
            ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants