forked from drogus/apache-upload-progress-module
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Remove check_node function
Signed-off-by: Michał Pokrywka <michal.pokrywka@gmail.com>
- Loading branch information
Showing
1 changed file
with
1 addition
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3193a18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite like this commit (even though it is completely legal to do it) because of the source decentralization on node key checks.
The inline directive on the original check_node function had exactly the same effect even if the resulting code would have been a few instruction longer. Those additional instructions where to make the return value a bit more deterministic but would be optimized away by the compiler thus in actual usage of this function there'd be no difference.
Also keeping this function would allow for better sanity checking when retrieving keys (using the check_node functions for code assertions).