Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataManagementSetup inconsistency #468

Closed
Drutol opened this issue Aug 24, 2020 · 0 comments · Fixed by #479
Closed

DataManagementSetup inconsistency #468

Drutol opened this issue Aug 24, 2020 · 0 comments · Fixed by #479

Comments

@Drutol
Copy link
Contributor

Drutol commented Aug 24, 2020

DataManagementSetup is not an abstract class yet the Start() method has protected access modifier effectively forcing user to inherit it to make any use of its functionality.

This method is also contained within #region private region so could it be a typo or is it a deliberate decision?

This design forces me to create dummy class like this for example:

    public class AutoWiredDataManagementSetup : DataManagementSetup
    {
        public void Run()
        {
            Start();
        }
    }
@mpostol mpostol self-assigned this Aug 25, 2020
@mpostol mpostol added this to the Networking.Gateway2Azure milestone Aug 25, 2020
@mpostol mpostol added the Feature request Consider to apply label Sep 10, 2020
mpostol added a commit that referenced this issue Sep 14, 2020
- added `abstract` prefix
- improved UT to fix compiler errors.
- UT 👍

-fixes #468
mpostol added a commit that referenced this issue Sep 14, 2020
DataManagementSetup inconsistency #468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants