Adjust logging behaviour #6

Merged
merged 2 commits into from Oct 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

glenngillen commented Oct 4, 2012

Looks like ActiveSupport::Concerns already have access to a logger, and by default logging a user's email address in plain-text is unlikely to get past our security guys.

garygreyling added a commit that referenced this pull request Oct 4, 2012

@garygreyling garygreyling merged commit 276513b into mpowered:master Oct 4, 2012

Contributor

garygreyling commented Oct 4, 2012

Thanks Glenn :) CMS 1.0.2 is out :)

Contributor

garygreyling commented Oct 5, 2012

Hi Glenn, just so that you're aware: I've reverted the use of AR's logger. I overlooked the fact that the use of AR's #logger meant the gem would no longer log to log/cm_subscriber.log. I have, however, retained your changes to only logging emails as a debug message. Thanks for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment