Skip to content

[feedback] Azan subuh berkumandang dilain waktu #173

Closed

Description

@fire-bot

Sent by Malaysia Prayer Time MPT. Created by fire.


---------- Forwarded message ---------
From: MPT Support <mptwaktusolat@gmail.com>
Date: Thu, 9 Feb 2023, 19:52
Subject: MPT report received (MPT-128A9)
To:

MPT Support

Dear user, thank you for submitting your valuable feedback.

On: Thursday, 9 February 2023, 19:40 MYT

You said that: Azan tidak tepat dengan waktu azan dan azan subuh berkumandang dilain waktu.

User email: __

App version: 2.7.3 (119)

Thanks for reaching out! This automated message lets you know we've received your feedback. The developer will respond to your feedback soon. Hang tight!

In the meantime, visit our GitHub to see about currently open issues.

To learn more about features and troubleshooting tips for the app, visit our website at waktusolat.iqfareez.com

Activity

  1. changed the title [-]Fwd: MPT report received (MPT-128A9)[/-] [+][feedback] Azan tidak tepat dengan waktu azan dan azan subuh berkumandang dilain waktu[/+] on Feb 18, 2023
  2. iqfareez commented on Feb 18, 2023

    @iqfareez
    Member

    Device info:

    image

    Related to #133, #136, #131, #115?

  3. changed the title [-][feedback] Azan tidak tepat dengan waktu azan dan azan subuh berkumandang dilain waktu[/-] [+][feedback] Azan subuh berkumandang dilain waktu[/+] on Mar 4, 2023
  4. self-assigned this
    on Mar 4, 2023
  5. iqfareez commented on Mar 4, 2023

    @iqfareez
    Member

    Changing this scope of this issue. Sorry, I'm not notice of this issue earlier until I've experienced it.

    So the issue is, when user set to long azan, the azan will play Subuh's azan (with assolatu khairun min annaum), for every prayer time (zuhr, asar, etc.).

    Also reported though review:
    image

    I'll try to fix this issue today and inshallah, try to issue an update later today. 💪

  6. iqfareez commented on Mar 4, 2023

    @iqfareez
    Member

    This issue was caused by this commit 15c6908#diff-201d9a5130b365544310ceb6343c82f16aabe2377aa8bc11440b1aea865e1dc8.

    I mistakenly assign all prayer times to be fajr azans. Astaghfirullah.

    customSound: short ? 'azan_short_lamy2005' : 'azan_hejaz2013_fajr',

  7. iqfareez commented on Mar 4, 2023

    @iqfareez
    Member

    The fixes are simple, just replace back theazan_hejaz2013_fajr to azan_kurdhi2010 for affected prayer times.

    But, as quoted from https://pub.dev/packages/flutter_local_notifications#custom-notification-icons-and-sounds

    ⚠️ For Android 8.0+, sounds and vibrations are associated with notification channels and can only be configured when they are first created. Showing/scheduling a notification will create a channel with the specified id if it doesn't exist already. If another notification specifies the same channel id but tries to specify another sound or vibration pattern then nothing occurs.

    Which means, if I understand correctly, we need to change the notification channel id. So we need to gives a new Id to the affected channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcriticalNeed quic fix!

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions