No maghrib notification was scheduled

[iqfareez]

Found in 2.8.1 (i'm not sure previous version would contain this bug or not)

When looking into the scheduled notification. No maghrib time was found.

But scrolling down a bit, there was a few maghrib time has been scheduled

So, what caused the most maghrib time cannot be scheduled??

[iqfareez]

The number of times the function to schedule the notification was hit is the same

I/flutter ( 8376): _maghribScheduler
I/flutter ( 8376): 19
I/flutter ( 8376): _ishaScheduler
I/flutter ( 8376): 19

[iqfareez]

Counting the number of schedule notification :

// calculate the amout you find the word maghrib
                var maghribCount = snapshot.data!
                    .where((element) => element.title!.contains('Maghrib'))
                    .length;

                // calculate the amout you find the word fajr
                var fajrCount = snapshot.data!
                    .where((element) => element.title!.contains('Fajr'))
                    .length;

snapshot.data is from List<PendingNotificationRequest>

I/flutter ( 8376): maghribCount: 15
I/flutter ( 8376): fajrCount: 18

It supposed to be the same

[iqfareez]

Ok, this time baru ada error message keluar..

I/flutter ( 8376): ----------------FIREBASE CRASHLYTICS----------------
I/flutter ( 8376): Invalid argument (id): must fit within the size of a 32-bit integer i.e. in the range [-2^31, 2^31 - 1]: 1686597900000
I/flutter ( 8376):
I/flutter ( 8376): #0      validateId
helpers.dart:6
I/flutter ( 8376): #1      AndroidFlutterLocalNotificationsPlugin.zonedSchedule
platform_flutter_local_notifications.dart:199
I/flutter ( 8376): #2      FlutterLocalNotificationsPlugin.zonedSchedule
flutter_local_notifications_plugin.dart:388
I/flutter ( 8376): #3      scheduleSinglePrayerNotification
notifications_helper.dart:49
I/flutter ( 8376): #4      MyNotifScheduler._defaultScheduler
notification_scheduler.dart:120
I/flutter ( 8376): <asynchronous suspension>
I/flutter ( 8376): ----------------------------------------------------

Edit: This error not related to the actual bug. Sorry

[iqfareez]

Fixed it.

So, what I had in mind is there might be notification id collision, so it invalidates the previously scheduled notification.

So, I changed the implementation to get the ID from timestamp by removing the trailing zeros for all prayers.

@@ -68,8 +68,9 @@ class MyNotifScheduler {
         //to make sure the time is in future
         await scheduleSinglePrayerNotification(
           name: 'Fajr',
-          id: int.parse(
-              dayTime.fajr.millisecondsSinceEpoch.toString().substring(5)),
+          id: int.parse(dayTime.fajr.millisecondsSinceEpoch
+              .toString()
+              .replaceAll(RegExp(r'0+$'), "")),

[iqfareez]

Fixed it.

So, what I had in mind is there might be notification id collision, so it invalidates the previously scheduled notification.

I have proven that indeed, the previous implementation of getting the id may having duplicates, so some notifications are not scheduled properly. (I'm not expecting they have many clashes like this one)

Code: https://dartpad.dev/76c2a5932300fa962a08a36788642625

On 2023-06-01 19:22:00.000 (Maghrib time), the millis representative is 1685618520000 (ms). Coincidentally, on 2023-06-15 16:42:00.000 (Asar time), the millis representative is 1686818520000

     id: int.parse(
         dayTime.fajr.millisecondsSinceEpoch.toString().substring(5)),

When doing the previous implementation, the first id is 18520000 and the other one is also 18520000

When I try to use the latest implementation.

      id: int.parse(dayTime.fajr.millisecondsSinceEpoch
          .toString()
         .replaceAll(RegExp(r'0+$'), "")),

There are no duplicates found. 👍