Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save position is common for all file #169

Closed
Geobert opened this issue Feb 3, 2019 · 4 comments
Closed

save position is common for all file #169

Geobert opened this issue Feb 3, 2019 · 4 comments
Labels

Comments

@Geobert
Copy link

Geobert commented Feb 3, 2019

With "save to position" enable (build 231), when using a external explorer, opening a video file, quitting (using back) and opening a new video, this new video start at the position saved for the other video

@sfan5
Copy link
Member

sfan5 commented Feb 3, 2019

This is due to content:// URIs being resolved into just a file description from the view of libmpv.
An easy possible fix would be to override the path mpv hashes for saving positions, if that's possible.

@sfan5 sfan5 added the bug label Feb 3, 2019
@wnoun
Copy link

wnoun commented May 26, 2019

We can hook on_load, then pass content URIs to mpv and set stream-open-filename in hook with the file descriptor. Also I think the stream_cb API is a right solution.

@sfan5
Copy link
Member

sfan5 commented May 26, 2019

We used to have a stream_cb based solution, but this was dropped in favor of resolving the fd in the Java part. Maybe it's time to reintroduce that.

@sfan5
Copy link
Member

sfan5 commented Oct 22, 2019

This is mostly fixed by 65478aa, though the bug will still happen with some apps (e.g. Google Drive).
The bug will be fully fixed when the stream_cb solution is added again (probably soon).

@sfan5 sfan5 closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants