New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add help overlay for keyboard shortcuts (triggered with ?) to the overlay UI. #2590

Open
shmerl opened this Issue Dec 14, 2015 · 10 comments

Comments

Projects
None yet
9 participants
@shmerl
Copy link

shmerl commented Dec 14, 2015

mpv has a lot of handy keyboard shortcuts, but without thoroughly studying man page or experimenting with all kind of combinations it's hard to figure out what does what.

It could be good to make some help overlay UI showing up in the player when user presses ? for example (similar to how Gmail does that). And making it in the form that mimics keyboard layout would be even better.

@kevinlekiller

This comment has been minimized.

Copy link

kevinlekiller commented Dec 14, 2015

You can already kind of do this: mpv --input-test --force-window --idle

https://mpv.io/manual/master/#options-input-test

https://mpv.io/manual/master/#command-interface

@shmerl

This comment has been minimized.

Copy link

shmerl commented Dec 14, 2015

Interesting, but it's not exactly as user friendly as keyboard layout popping up on ? key press.

@AirPort

This comment has been minimized.

Copy link

AirPort commented Dec 14, 2015

@shmerl

This comment has been minimized.

Copy link

shmerl commented Dec 14, 2015

@AirPort : Yep, something like that showing up in the UI on ? key press would be good.

@rrooij

This comment has been minimized.

Copy link
Contributor

rrooij commented Dec 22, 2015

Maybe it is a good idea to have a Lua script for this kind of behavior. My suggestions for this:

  • Use the default OSD for displaying the keyboard layout
  • Bind the keys as specified in the user's input.conf. If the user has other key options, display those instead of the default keys.

The only issue I see with a Lua script is that it will require Lua to display the OSC keyboard. But to be fair, I don't think that this feature will be used by people not having Lua installed

@wm4

This comment has been minimized.

Copy link
Contributor

wm4 commented Dec 22, 2015

That all sounds nice and fun, but who will figure out how to make a nice layout, and a way to map the (sometimes cryptic) commands to a nice help text?

@wm4

This comment has been minimized.

Copy link
Contributor

wm4 commented Oct 9, 2017

and a way to map the (sometimes cryptic) commands to a nice help text?

On that topic, it might be possible to associate a help text each binding in the default input.conf - maybe. Still leaves the question how to nicely layout it.

@bricewge

This comment has been minimized.

Copy link

bricewge commented Oct 9, 2017

It seems to me that the UI of Emacs' Hydra can be a good fit for the help OSD, here are some examples of it.

It is a list all the binded commands, prefixed by the key that trigger it or if the letter of key is part of the command it is highlighted, like this:

  • quit
  • subtitle visibility
  • > previous file
  • 3 brightness -
    It help in remembering the keys by suggesting a mnemonic.
@BurhanDanger

This comment has been minimized.

Copy link

BurhanDanger commented Jul 31, 2018

Is is possible to create something similar to 'command palette' like in sublime-text? Currently in input.conf there are two values , bound key and bound command. A third optional value can be added where user can write their bindkey description. That when present will show against that key binding(in command palette), if absent show the bound command.

@hi2u

This comment has been minimized.

Copy link

hi2u commented Jul 31, 2018

Something like the screen you see when you hit ? in Gmail would be awesome (especially if it accounts for your current key config rather than being hard-coded to the defaults)...

gmail-keyboard-help

I rarely need to use anything aside from seeking, pausing and quitting, but when I do it's a bit annoying having to get off the couch and go up to a computer and search online or read help files to do something that should be as a quick as a single keypress or click. I've tried remembering the keys, but I don't use any of the functions enough to remember them. So most of the time I can't be bothered and just open VLC to get it done quickly and get back to watching my video.

I really prefer MPV, but I think these kind of easy-of-use things could make it much better and more popular. Even some of my friends that run Linux media boxes stick to VLC for these reasons, I haven't been able to sell them on MPV.

Hope I don't sound like a whinger, just want to see MPV come along in this area a bit so that I and others can use it more often.

There also is this official bindings' chart: https://github.com/mpv-player/random-stuff/blob/master/key_bindings_chart/mpbindings.png

To me these kinds of charts are more useful when you've just accidentally hit a key and want to know what you just did (kind of reverse engineering). Otherwise when you trying to figure how to do something, you have to basically read through the entire thing every time.

Anyway, thanks for all your work on MPV, it's a great player in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment