Subtitles do not work in mpv 0.16.0

[LoneFox78]

[sub/ass] Could not open libavcodec subtitle converter
[sub] Could not find subtitle decoder for format 'srt'.

This seems to be yet another difference between libav and ffmpeg. In libav, av_malloc(0) returns NULL. In ffmpeg, it passes the parameter to malloc(), and return value depends on libc implementation (and I believe glibc returns a valid pointer in this case).
Suggested fix:

diff -ur mpv-0.16.0-orig/sub/lavc_conv.c mpv-0.16.0/sub/lavc_conv.c
--- mpv-0.16.0-orig/sub/lavc_conv.c     2016-02-29 01:22:04.000000000 +0200
+++ mpv-0.16.0/sub/lavc_conv.c  2016-02-29 18:41:16.000000000 +0200
@@ -79,11 +79,13 @@
     avctx = avcodec_alloc_context3(codec);
     if (!avctx)
         goto error;
-    avctx->extradata_size = extradata_len;
-    avctx->extradata = av_malloc(extradata_len);
-    if (!avctx->extradata)
-        goto error;
-    memcpy(avctx->extradata, extradata, extradata_len);
+    if (extradata_len > 0) {
+        avctx->extradata_size = extradata_len;
+        avctx->extradata = av_malloc(extradata_len);
+        if (!avctx->extradata)
+            goto error;
+        memcpy(avctx->extradata, extradata, extradata_len);
+    }
     if (strcmp(codec_name, "eia_608") == 0)
         av_dict_set(&opts, "real_time", "1", 0);
     if (avcodec_open2(avctx, codec, &opts) < 0)

[ghost]

av_malloc(0) is probably just as OS-specific as malloc(0). Fixed slightly different, but should amount to the same thing.

[evgkrsk]

Same problem in v0.19.0 with at least some mediafiles:

[sub/ass] Could not open libavcodec subtitle converter
[sub] Could not find subtitle decoder for format 'subrip'.

[ghost]

Uh ok? Great way to get your bug report ignored.

[ghost]

(PS: this means you should report your bug properly.)