Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD] osc.lua crashes #3210

Closed
zhangn1985 opened this Issue Jun 4, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@zhangn1985
Copy link

zhangn1985 commented Jun 4, 2016

when playing a playlist. eg mpv VIDEO0 VIDEO1.....
click forward button on OSD control panel, when first video VIDEO0 is almost finished. eg left 2s

and OSD gets crashed. and no OSD control panel for next video.

reproduce rate is 80%, easy to reproduce.

here is crash log:

[osc] 
[osc] stack traceback:
[osc]   @osc.lua:2048: in function 'cb'
[osc]   mp.defaults:107: in function 'fn'
[osc]   mp.defaults:60: in function 'handler'
[osc]   mp.defaults:339: in function 'handler'
[osc]   mp.defaults:441: in function 'call_event_handlers'
[osc]   mp.defaults:477: in function 'dispatch_events'
[osc]   mp.defaults:434: in function <mp.defaults:433>
[osc]   [C]: at 0x00475a70
[osc]   [C]: at 0x00476c80
[osc] Lua error: @osc.lua:1894: attempt to index a nil value

here is mpv version:

mpv git-68c77d9 (C) 2000-2016 mpv/MPlayer/mplayer2 projects
 built on Tue May 31 08:25:36 CST 2016
ffmpeg library versions:
   libavutil       55.17.103
   libavcodec      57.24.102
   libavformat     57.25.100
   libswscale      4.0.100
   libavfilter     6.31.100
   libswresample   2.0.101
ffmpeg version: 3.0.2-2~bpo8+1

Usage:   mpv [options] [url|path/]filename

lua version: libluajit-5.1 from debian 8.3

@zhangn1985

This comment has been minimized.

Copy link
Author

zhangn1985 commented Jun 4, 2016

crash with lua5.2deb:

[osc] 
[osc] stack traceback:
[osc]   @osc.lua:1894: in function 'process_event'
[osc]   @osc.lua:2048: in function 'cb'
[osc]   mp.defaults:107: in function 'fn'
[osc]   mp.defaults:60: in function 'handler'
[osc]   mp.defaults:339: in function 'handler'
[osc]   mp.defaults:441: in function 'call_event_handlers'
[osc]   mp.defaults:477: in function 'dispatch_events'
[osc]   mp.defaults:434: in function <mp.defaults:433>
[osc]   [C]: in ?
[osc]   [C]: in ?
[osc] Lua error: @osc.lua:1894: attempt to index field 'eventresponder' (a nil value)

@ChrisK2 ChrisK2 self-assigned this Jun 4, 2016

@zhangn1985

This comment has been minimized.

Copy link
Author

zhangn1985 commented Jun 7, 2016

it's easy to reproduce it when playing on line video.
i can't reproduce when playing local video.

@lachs0r

This comment has been minimized.

Copy link
Member

lachs0r commented Nov 6, 2016

You can also trigger this very easily by dragging the seek slider while the next video in a playlist is loading.

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Nov 7, 2016

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Nov 7, 2016

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Nov 7, 2016

@wiiaboo wiiaboo closed this in 5beb230 Nov 8, 2016

@zhangn1985

This comment has been minimized.

Copy link
Author

zhangn1985 commented Nov 9, 2016

@wiiaboo thanks!

rohieb added a commit to rohieb/mpv that referenced this issue Jan 21, 2017

osc: fix crashes related to field eventresponder being nil
I'm still getting some crashes after issue mpv-player#3210 was fixed in commit
5beb230. It's hard to reproduce those
crashes, they happen maybe once a month, so I guess it could be a race
condition. But in any case, I don't see anything wrong in applying some
defensive programming here.

For reference, here is what was happening on 0.23.0-1 from Debian
testing:

  Playing: ytdl://usL5CeP_row
   (+) Video --vid=1 (*) (h264)
    (+) Audio --aid=1 --alang=und (*) (aac)
    [osc]
    [osc] stack traceback:
    [osc]	  @osc.lua:2074: in function 'process_event'
    [osc]	  @osc.lua:2246: in function 'cb'
    [osc]	  mp.defaults:107: in function 'fn'
    [osc]	  mp.defaults:60: in function 'handler'
    [osc]	  mp.defaults:339: in function 'handler'
    [osc]	  mp.defaults:448: in function 'call_event_handlers'
    [osc]	  mp.defaults:485: in function 'dispatch_events'
    [osc]	  mp.defaults:441: in function <mp.defaults:440>
    [osc]	  [C]: in ?
    [osc]	  [C]: in ?
    [osc] Lua error: @osc.lua:2074: attempt to index field 'eventresponder' (a nil value)

Note that the location is different from where issue mpv-player#3210 happens.

rohieb added a commit to rohieb/mpv that referenced this issue Jan 21, 2017

osc: fix crashes related to field eventresponder being nil
I'm still getting some crashes after issue mpv-player#3210 was fixed in commit
5beb230. It's hard to reproduce those
crashes, they happen maybe once a month, so I guess it could be a race
condition. But in any case, I don't see anything wrong in applying some
defensive programming here.

For reference, here is what was happening on 0.23.0-1 from Debian
testing:

  Playing: ytdl://usL5CeP_row
   (+) Video --vid=1 (*) (h264)
    (+) Audio --aid=1 --alang=und (*) (aac)
    [osc]
    [osc] stack traceback:
    [osc]	  @osc.lua:2074: in function 'process_event'
    [osc]	  @osc.lua:2246: in function 'cb'
    [osc]	  mp.defaults:107: in function 'fn'
    [osc]	  mp.defaults:60: in function 'handler'
    [osc]	  mp.defaults:339: in function 'handler'
    [osc]	  mp.defaults:448: in function 'call_event_handlers'
    [osc]	  mp.defaults:485: in function 'dispatch_events'
    [osc]	  mp.defaults:441: in function <mp.defaults:440>
    [osc]	  [C]: in ?
    [osc]	  [C]: in ?
    [osc] Lua error: @osc.lua:2074: attempt to index field 'eventresponder' (a nil value)

Note that the location is different from where issue mpv-player#3210 happens.

Signed-off-by: Roland Hieber <rohieb@rohieb.name>

rohieb added a commit to rohieb/mpv that referenced this issue Jan 21, 2017

osc: fix crashes related to field eventresponder being nil
I'm still getting some crashes after issue mpv-player#3210 was fixed in commit
5beb230. It's hard to reproduce those
crashes, they happen maybe once a month, so I guess it could be a race
condition. But in any case, I don't see anything wrong in applying some
defensive programming here.

For reference, here is what was happening on 0.23.0-1 from Debian
testing:

  Playing: ytdl://usL5CeP_row
   (+) Video --vid=1 (*) (h264)
    (+) Audio --aid=1 --alang=und (*) (aac)
    [osc]
    [osc] stack traceback:
    [osc]	  @osc.lua:2074: in function 'process_event'
    [osc]	  @osc.lua:2246: in function 'cb'
    [osc]	  mp.defaults:107: in function 'fn'
    [osc]	  mp.defaults:60: in function 'handler'
    [osc]	  mp.defaults:339: in function 'handler'
    [osc]	  mp.defaults:448: in function 'call_event_handlers'
    [osc]	  mp.defaults:485: in function 'dispatch_events'
    [osc]	  mp.defaults:441: in function <mp.defaults:440>
    [osc]	  [C]: in ?
    [osc]	  [C]: in ?
    [osc] Lua error: @osc.lua:2074: attempt to index field 'eventresponder' (a nil value)

Note that the location is different from where issue mpv-player#3210 happens.

Signed-off-by: Roland Hieber <rohieb@rohieb.name>

wm4 pushed a commit that referenced this issue Jan 25, 2017

osc: fix crashes related to field eventresponder being nil
I'm still getting some crashes after issue #3210 was fixed in commit
5beb230. It's hard to reproduce those
crashes, they happen maybe once a month, so I guess it could be a race
condition. But in any case, I don't see anything wrong in applying some
defensive programming here.

For reference, here is what was happening on 0.23.0-1 from Debian
testing:

  Playing: ytdl://usL5CeP_row
   (+) Video --vid=1 (*) (h264)
    (+) Audio --aid=1 --alang=und (*) (aac)
    [osc]
    [osc] stack traceback:
    [osc]	  @osc.lua:2074: in function 'process_event'
    [osc]	  @osc.lua:2246: in function 'cb'
    [osc]	  mp.defaults:107: in function 'fn'
    [osc]	  mp.defaults:60: in function 'handler'
    [osc]	  mp.defaults:339: in function 'handler'
    [osc]	  mp.defaults:448: in function 'call_event_handlers'
    [osc]	  mp.defaults:485: in function 'dispatch_events'
    [osc]	  mp.defaults:441: in function <mp.defaults:440>
    [osc]	  [C]: in ?
    [osc]	  [C]: in ?
    [osc] Lua error: @osc.lua:2074: attempt to index field 'eventresponder' (a nil value)

Note that the location is different from where issue #3210 happens.

Signed-off-by: Roland Hieber <rohieb@rohieb.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.