New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--window-size broken when using per-file markers #3724

Closed
bergfried opened this Issue Oct 25, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@bergfried

bergfried commented Oct 25, 2016

The --window-size option does not work properly with --{ and --} anymore. Only the very first encounter of --window-scale will be accepted but applied to all files, regardless of whether they are enclosed by the same per-file markers or not. Any subsequent encounter of --window-scale while playing will result in an

Error parsing option window-scale (option could not be parsed)

and will be rejected. Even --loop with only one file will do that as soon as the file is being played more than once. Examples:

mpv '--{' --window-scale=0.5 somefile '--}' '--{' --window-scale=0.25 otherfile '--}'
mpv --loop '--{' --window-scale=0.5 somefile '--}'

Using mpv 0.21.

@wm4

This comment has been minimized.

Contributor

wm4 commented Oct 25, 2016

This happens because at the time of setting the second option there is a window, but no video size known, so it's rejected.

@wm4 wm4 closed this in ee4bed2 Oct 25, 2016

@bergfried

This comment has been minimized.

bergfried commented Oct 25, 2016

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment