New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seekbar [with OSC slimbox layout] #3737

Closed
sh3rry opened this Issue Oct 27, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@sh3rry

sh3rry commented Oct 27, 2016

with style of the seekbar --> bar (fill)
White strip is out of the progress bar range when using layout ”slimbox“ ,sometimes looks ugly。

@sh3rry

This comment has been minimized.

sh3rry commented Oct 27, 2016

possible use rounded corners

@sh3rry

This comment has been minimized.

sh3rry commented Oct 27, 2016

image

@wiiaboo

This comment has been minimized.

Member

wiiaboo commented Oct 27, 2016

@ChrisK2 I assume rounded corners for the seekbar are still expensive to render? (can't remember where I read this)
So a likely fix in time for 0.21.1 would be
image

@sh3rry

This comment has been minimized.

sh3rry commented Oct 27, 2016

@wiiaboo | isn't a bad idea, either :)

@ghost

This comment has been minimized.

ghost commented Oct 27, 2016

How about just remove the rounded corners? Make it something like this instead:
image

@wiiaboo

This comment has been minimized.

Member

wiiaboo commented Oct 27, 2016

I'd prefer something like #2365 with slimbox.

@firewater2

This comment has been minimized.

firewater2 commented Oct 29, 2016

I'm gonna jump on this and ask if it's possible to remove the chapter markets from the bar?

@ChrisK2

This comment has been minimized.

Member

ChrisK2 commented Oct 29, 2016

I assume rounded corners for the seekbar are still expensive to render?

Yes. And will always be, at least with the current way the OSC works.

So a likely fix in time for 0.21.1 would be ...

No no, don't touch this. This layout should only be used together with seekbarstyle=slider. If you make those changes you'll ruin the look of slider (unless the changes only apply when using bar).

How about just remove the rounded corners? Make it something like this instead: ...

Yeah, implementing this as yet another layout would be the best solution for those who insist on using the bar style.

I'm gonna jump on this and ask if it's possible to remove the chapter markets from the bar?

No.

@ChrisK2 ChrisK2 changed the title from seekbar to seekbar [with OSC slimbox layout] Oct 29, 2016

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Nov 7, 2016

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Nov 7, 2016

@wiiaboo wiiaboo closed this in 8b7f231 Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment