New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC playlist randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes' #4081

Closed
Coacher opened this Issue Jan 28, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@Coacher
Contributor

Coacher commented Jan 28, 2017

Hello.

mpv version and platform

Reproducible with mpv-0.2{1,2,3}.0 or mpv-git @ 9c90c90 on Gentoo amd64.

Reproduction steps

  1. Open playlist with several files and make sure the video window is opened.
  2. Click 'pl prev'/'pl next' buttons in OSC in the video window.

Expected behavior

Playback switches to the previous/next file and the displayed OSD has normal size.

Actual behavior

Playback switches to the previous/next file and the displayed OSD changes size from normal to huge at random.

Log file

mpv 0.23.0 logfile: http://sprunge.us/RiHS
mpv-git logile: http://sprunge.us/XKAZ
ffmpeg -f x11grab output: https://0x0.st/VoU.mp4

Please fix.

@Coacher Coacher changed the title from OSD randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC to OSD randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes' Jan 28, 2017

@Coacher

This comment has been minimized.

Contributor

Coacher commented Jan 28, 2017

Not reproducible when there is actual video.

@mc4man

This comment has been minimized.

mc4man commented Jan 29, 2017

If scalefullscreen= & scaleforcedwindow= are the same value then you'd likely get consistent results, after that the results could be quite unexpected.
i'd think typically users would have scalefullscreen a lower value than scaleforcedwindow which produces poor results at times depending on values used.
The most unexpected is a high scalefullscreen with a low scaleforcedwindow which makes the playlist smaller the higher scalefullscreen goes and or the lower scaleforcedwindow goes.

Can't see why for audio only thru the pseudo-gui one would want to go fullscreen..

@Coacher

This comment has been minimized.

Contributor

Coacher commented Jan 29, 2017

@mc4man, this issue isn't about consistency, but about weird scaling glitches. See demo video in OP.

@mc4man

This comment has been minimized.

mc4man commented Jan 30, 2017

@Coacher

This comment has been minimized.

Contributor

Coacher commented Jan 31, 2017

@mc4man, I misunderstood your first comment.
Indeed, if I set scalewindowed, scalefullscreen, scaleforcedwindow to 1, then these glitches no longer happen. Default values cause these glitches though.

It would be nice to have non-problematic default values or fix the underlying bug.

@Coacher Coacher changed the title from OSD randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes' to OSC playlist randomly changes size when clicking 'pl prev'/'pl next' buttons in OSC with '--force-window=yes' Feb 1, 2017

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Feb 3, 2017

osc: refactor osc message scaling
Will still hide playlist items with long enough filenames and osd-font-size
but not as soon.

osc messages should now preserve their scaling with fullscreen toggling and
cycling through audio-only files and files with video.

Closes mpv-player#4081, mpv-player#4083, mpv-player#4102

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Feb 3, 2017

osc: refactor osc message scaling
Will still hide playlist items with long enough filenames and osd-font-size
but not as soon.

osc messages should now preserve their scaling with fullscreen toggling and
cycling through audio-only files and files with video.

Closes mpv-player#4081, mpv-player#4083, mpv-player#4102

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Feb 5, 2017

osc: refactor osc message scaling
Will still hide playlist items with long enough filenames and osd-font-size
but not as soon.

osc messages should now preserve their scaling with fullscreen toggling and
cycling through audio-only files and files with video.

Closes mpv-player#4081, mpv-player#4083, mpv-player#4102

wiiaboo added a commit to wiiaboo/mpv that referenced this issue Mar 24, 2017

osc: refactor osc message scaling
Will still hide playlist items with long enough filenames and osd-font-size
but not as soon.

osc messages should now preserve their scaling with fullscreen toggling and
cycling through audio-only files and files with video.

Closes mpv-player#4081, mpv-player#4083, mpv-player#4102

@wiiaboo wiiaboo closed this in bcb2db0 Mar 24, 2017

atomnuker added a commit to atomnuker/mpv that referenced this issue Jun 4, 2017

osc: refactor osc message scaling
Will still hide playlist items with long enough filenames and osd-font-size
but not as soon.

osc messages should now preserve their scaling with fullscreen toggling and
cycling through audio-only files and files with video.

Closes mpv-player#4081, mpv-player#4083, mpv-player#4102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment