New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwdec-current property does not get updated when changing hwdec #4289

Closed
romaincointepas opened this Issue Mar 30, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@romaincointepas

romaincointepas commented Mar 30, 2017

mpv version and platform

  • Both 0.24 and master (c68be80a63f100d1a55d8be7273c89734d6abeeb)
  • macOS Sierra 10.12.4

Reproduction steps

Using the client API:

  • observe hwdec-current
  • init mpv with --opengl-hwdec-interop=auto and--hwdec=auto
  • play a video
  • I do get hwdec-current changed to videotoolbox-copy when playback starts
  • a few seconds later, set --hwdec=no (can confirm it switched back to software decoding)

Expected behavior

Receive a change in hwdec-current (should become no)

Actual behavior

Not receiving any changes for hwdec-current.


Also, after doing --hwdec=no, switching back to --hwdec=auto again does switch back to videotoolbox (can confirm hardware decoding), but hwdec-current never changes.

wm4 pushed a commit that referenced this issue Mar 31, 2017

wm4
command: add property notifications for hwdec properties
This is a bit approximate, because we rely on the pixel format changing
if the hardware decoding changes. This is not always true, as the pixel
format for software decoded video and hardware decoded video copied back
to CPU RAM could be the same. (Not sure if that is actually the case for
any supported cases.)

But for now this should fix most of #4289.
@wm4

This comment has been minimized.

Contributor

wm4 commented Mar 31, 2017

Above commit should fix most of this.

@wm4 wm4 closed this Mar 31, 2017

@romaincointepas

This comment has been minimized.

romaincointepas commented Apr 1, 2017

@wm4 Thanks!

atomnuker added a commit to atomnuker/mpv that referenced this issue Jun 4, 2017

command: add property notifications for hwdec properties
This is a bit approximate, because we rely on the pixel format changing
if the hardware decoding changes. This is not always true, as the pixel
format for software decoded video and hardware decoded video copied back
to CPU RAM could be the same. (Not sure if that is actually the case for
any supported cases.)

But for now this should fix most of mpv-player#4289.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment