New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when opening a file. #4315

Closed
DeadSix27 opened this Issue Apr 12, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@DeadSix27

DeadSix27 commented Apr 12, 2017

Version: 7497b63 (Compiled with GCC 6.3.0 mingw)
OS: Win8.1 64bit
Crashes when opening a video file, I guess it has something to do with:

https://github.com/mpv-player/mpv/commit/7497b633e9ffbc48cda46215b2d5b1194a3b3a5f.diff

in the newest commit since the one right before that works fine.
(Not sure if this is a obvious issue.)
The log doesn't output anything out of the ordinary, if you still want it tell me.
(I don't exactly know how to use gdb or VS to debug the build, if you need that I'd need some instructions.)

@Warblefly

This comment has been minimized.

Warblefly commented Apr 12, 2017

Same for me on Windows 10 64 bit, compiled with GCC 6.3.1 mingw. Crash is error 0xc0000374 in RtlNonEmptyDirectoryReparsePointAllowed() in ntdll.dll

I have not yet had a chance to test this commit-by-commit and am not by the computer right now to send the full trace. Will do so in the morning.

@wm4

This comment has been minimized.

Contributor

wm4 commented Apr 12, 2017

Can't reproduce. Is anything specific needed?

@wm4 wm4 added the ms-windows label Apr 12, 2017

@Warblefly

This comment has been minimized.

Warblefly commented Apr 12, 2017

I confirm on my Windows 10 Insider Build 16170 that the error occurs at 7497b63. Building from the master tree immediately before this commit runs perfectly.

On the faulty build, it is possible to start mpv with the mpv --idle command; but as soon as a file is dropped onto the opened player window, the crash happens.

Here is the gdb backtrace, as far as it gets:

#0  0x00007ffaab6d5c1f in ntdll!RtlIsNonEmptyDirectoryReparsePointAllowed () from C:\WINDOWS\SYSTEM32\ntdll.dll
#1  0x00007ffaab6dc2fa in ntdll!RtlpNtSetValueKey () from C:\WINDOWS\SYSTEM32\ntdll.dll
#2  0x00007ffaab685012 in ntdll!RtlIsPartialPlaceholderFileInfo () from C:\WINDOWS\SYSTEM32\ntdll.dll
#3  0x00007ffaab698e4c in ntdll!memset () from C:\WINDOWS\SYSTEM32\ntdll.dll
#4  0x00007ffaaaf6998c in msvcrt!free () from C:\WINDOWS\System32\msvcrt.dll
#5  0x0000000000c9cc55 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)

@wm4 wm4 closed this in dc5dfa5 Apr 12, 2017

@wm4

This comment has been minimized.

Contributor

wm4 commented Apr 12, 2017

Staring at the code again, it was pretty obvious. But I didn't test this again.

@Warblefly

This comment has been minimized.

Warblefly commented Apr 12, 2017

I'm building it now.

@Warblefly

This comment has been minimized.

Warblefly commented Apr 12, 2017

Problem is cured on my system. Thank you for fixing this!

@DeadSix27

This comment has been minimized.

DeadSix27 commented Apr 12, 2017

@wm4 dc5dfa5 fixed it for me too, thanks.

atomnuker added a commit to atomnuker/mpv that referenced this issue Jun 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment