New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking screenshots may make subtitles corrupt #4325

Closed
nagisa opened this Issue Apr 17, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@nagisa

nagisa commented Apr 17, 2017

mpv version and platform

mpv git-bba08e38ff (C) 2000-2017 mpv/MPlayer/mplayer2 projects
 built on Sun Apr 16 17:01:43 EEST 2017
ffmpeg library versions:
   libavutil       55.58.100
   libavcodec      57.89.100
   libavformat     57.71.100
   libswscale      4.6.100
   libavfilter     6.82.100
   libswresample   2.7.100
ffmpeg version: 3.3

Reproduction steps

Watch an anime with AlphaSubstation subtitles. Take a screenshot.

Expected behavior

Screenshot is made and subtitles are shown correctly afterwards.

Actual behavior

Goes from
screenshot from 2017-04-17 12 24 26

to

screenshot from 2017-04-17 12-26-32

The extra screenshots made later on with mpv still look correct, despite the incorrect rendering on the screen.

Log file

http://sprunge.us/jJUK

Sample files

This is reproducible with 15th episode of Little Witch Academia from Asenshi, though I have been able to reproduce the same behaviour in a multiple cases for at least 3 months now.

https://0x0.st/xj-.mkv is a piece that I cut out with ffmpeg which can reproduce it. Interestingly it does not reproduce without the included custom font streams.

@shinchiro

This comment has been minimized.

Contributor

shinchiro commented Apr 17, 2017

I got same file. Taking screenshot with subtitle work correctly on windows though

@nguyenhimself

This comment has been minimized.

nguyenhimself commented Apr 17, 2017

Works fine for me with the latest stable release (v0.24.0 0f1afc6).

Sample screenshot.

Maybe give it a try with another build?

@wm4

This comment has been minimized.

Contributor

wm4 commented Apr 17, 2017

Seems like this happens with vo_vaapi only.

@nagisa

This comment has been minimized.

nagisa commented Apr 17, 2017

@wm4 indeed. Switching to any other vo works fine.

@wm4 wm4 closed this in ce4ab48 Apr 18, 2017

atomnuker added a commit to atomnuker/mpv that referenced this issue Jun 4, 2017

ass_mp: reallocate cached subtitle image data on format changes
When the format of the subtitle bitmaps changes, such as with taking
screenshots with vo_vaapi (RGBA for the VO vs. Y8 for screenshots), the
cache image obviously needs to be recreated.

Fixes mpv-player#4325.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment