New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON IPC and multiple external-file #4394

Closed
maiorfi-at-innovactive opened this Issue May 2, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@maiorfi-at-innovactive

maiorfi-at-innovactive commented May 2, 2017

It seems that this subject has been already discussed here and there, but I did not spot yet how to properly format json ipc message related to multiple external-file options.

I would like to use lavfi-complex property in order to get a 2x2 tiling with a loadfile command and 3 external-file items.

Thanks!

@wm4

This comment has been minimized.

Contributor

wm4 commented May 2, 2017

You have to set this as a mpv_node with the format set to MPV_FORMAT_NODE_ARRAY. Each array item would be a string with the filename of an external file.

It's not possible to set this as a simple string, because filenames could contain , (or any other separator that could be used).

@wm4 wm4 added the question label May 2, 2017

@wm4 wm4 closed this May 2, 2017

@maiorfi-at-innovactive

This comment has been minimized.

maiorfi-at-innovactive commented May 2, 2017

Sorry for reiterating on this, but I'm still wondering whether it is possible (and, in that case, how) express a mpv_node with MPV_FORMAT_NODE_ARRAY using JSON-IPC notation.

Thanks.

@wm4

This comment has been minimized.

Contributor

wm4 commented May 2, 2017

sure, if you use json IPC, it should accept a json array of strings.

@maiorfi-at-innovactive

This comment has been minimized.

maiorfi-at-innovactive commented May 3, 2017

Indeed I thought it should have been working with any of following two ways, but it didn't (below there are 2 request commands interleaved with corresponding reply event):

{ "command": ["set_property", "external-file", ["file1","file2"] ] }
{"error":"invalid parameter"}
{ "command": ["set_property", "external-file", "file1", "file2" ] }
{"error":"invalid parameter"}

Any suggestion?

wm4 pushed a commit that referenced this issue May 3, 2017

wm4
ipc: raise json nesting limit
Fixes the issue pointed out in #4394.
@wm4

This comment has been minimized.

Contributor

wm4 commented May 3, 2017

That should have worked, but didn't because it restricted nesting so that passing the file array was not possible. I fixed it now.

@maiorfi-at-innovactive

This comment has been minimized.

maiorfi-at-innovactive commented May 4, 2017

Great, thanks!

atomnuker added a commit to atomnuker/mpv that referenced this issue Jun 4, 2017

ipc: raise json nesting limit
Fixes the issue pointed out in mpv-player#4394.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment