Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Regression: failure to take screenshot with hwdec=vaapi #5240
mpv version and platform
png screenshot taken
first bad commit 522bfe5 (vo_gpu: don't re-render hwdec frames when repeating frames)
Not sure why this happens, when it apparently never happened with our old vaapi code. I don't think we try to access the image while it's written to, but surely it can happen while it's read from (like being used as reference frame during decoding, or when being displayed via GL). But surely, doing read accesses while it's used for other read accesses, it should work.
@fhvwy any ideas or comments?
Do we need some nonsense like staging surfaces, and could the libavutil code do this?