Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to make HDR look better on SDR display with MPV? #8484

Closed
laichiaheng opened this issue Jan 19, 2021 · 18 comments
Closed

Any way to make HDR look better on SDR display with MPV? #8484

laichiaheng opened this issue Jan 19, 2021 · 18 comments

Comments

@laichiaheng
Copy link

laichiaheng commented Jan 19, 2021

With default config, it loses hightlight details, it gets even worse without hdr-compute-peak. Here is a compare with default, default without hdr-compute-peak, hable, and MadVR.

  • default:
    2021-01-19 21-52-30 的螢幕擷圖

  • default without hdr-compute-peak:
    2021-01-19 21-52-58 的螢幕擷圖

  • hable:
    2021-01-19 21-54-00 的螢幕擷圖

  • MadVR:
    Snipaste_2021-01-13_22-42-49

The last one contains most of the details and have a brighter image.

Log file

hdr.txt

@wiiaboo
Copy link
Member

wiiaboo commented Jan 19, 2021

Have you tried different tone-mapping options?

@laichiaheng
Copy link
Author

laichiaheng commented Jan 19, 2021

Have you tried different tone-mapping options?

Yes, I've tried hable, reinhard, and mobius, but they are also too dark or lose high light details if I raise the brightness.

@Doofussy2
Copy link

Doofussy2 commented Jan 19, 2021

Have you tried tuning the params?
https://mpv.io/manual/master/#options-tone-mapping-param

And adjusting the max boost?
https://mpv.io/manual/master/#options-tone-mapping-max-boost

@avih
Copy link
Member

avih commented Jan 19, 2021

@Doofussy2 Are you familiar with sets of params to make mpv behave like common other mappers? (vlc/madvr/osx/etc)? if yes, would you be able to post these "presets" here or add them to the wiki someplace?

@laichiaheng
Copy link
Author

Have you tried tuning the params?
https://mpv.io/manual/master/#options-tone-mapping-param

And adjusting the max boost?
https://mpv.io/manual/master/#options-tone-mapping-max-boost

Adjusting max boost loses high light details, too.

@Doofussy2
Copy link

@Doofussy2 Are you familiar with sets of params to make mpv behave like common other mappers? (vlc/madvr/osx/etc)? if yes, would you be able to post these "presets" here or add them to the wiki someplace?

The problem with that is the results are inconsistent. I've fairly extensively tested the various parameters, and I have found to have varying results from video to video. Madshi appears to have written his algorithms a little differently, so applying the same params will look a little different. bt.2390 is the best at the moment, but isn't tunable. So haasn would need to make any revisions. Presently it does appear to lose detail in the white point. I don't know what other players use as default, but I could possibly research that. Time isn't on my side, these days.

@laichiaheng in your madvr screenshot, what algorithm were you using? Did you use bt.2390? I haven't used madvr in a while. I should probably get caught up.

@laichiaheng
Copy link
Author

laichiaheng commented Jan 20, 2021

@Doofussy2 Are you familiar with sets of params to make mpv behave like common other mappers? (vlc/madvr/osx/etc)? if yes, would you be able to post these "presets" here or add them to the wiki someplace?

The problem with that is the results are inconsistent. I've fairly extensively tested the various parameters, and I have found to have varying results from video to video. Madshi appears to have written his algorithms a little differently, so applying the same params will look a little different. bt.2390 is the best at the moment, but isn't tunable. So haasn would need to make any revisions. Presently it does appear to lose detail in the white point. I don't know what other players use as default, but I could possibly research that. Time isn't on my side, these days.

@laichiaheng in your madvr screenshot, what algorithm were you using? Did you use bt.2390? I haven't used madvr in a while. I should probably get caught up.

It's not mine, but the one who uploads it says that he didn't change any setting.

I also tried --tone-mapping=gamma, but the color just looked strange, some part of the image became grayish.

--tone-mapping=gamma=2.0
--tone-mapping-desaturate=0.5
--tone-mapping-desaturate-exponent=0
disable icc-profile

2021-01-20 01-47-49 的螢幕擷圖
2021-01-20 08-47-19 的螢幕擷圖
2021-01-20 08-47-33 的螢幕擷圖

@Doofussy2
Copy link

Doofussy2 commented Jan 20, 2021

OK, I had a quick few minutes for a basic comparison. Let's stick with Tenet for an apples to apples comparison.

First, we need a baseline. The first screenshot is the studio SDR master. This is the goal outcome.

--no-config
Tenet studio SDR no config

--no-config --hdr-compute-peak=no and using default tone-mapping (bt.2390)
Tenet no-config hdr compute-peak=no

We can see that it's slightly darker, but look at the white building in the background, center. Clearly there is a color shift and a loss of clarity.

--no-config --hdr-compute-peak=no --tone-mapping=reinhard
2 Reinhard default

Default reinhard is also a little darker, and that building still has a color shift but it does look a little better than bt.2390, I think.

--no-config --hdr-compute-peak=no --tone-mapping=reinhard --tone-mapping-param=0.6
Reinhard TMP 0 6

So now we see center stage with a brightness comparative to the studio SDR. The Building in the background is obviously not correct.

Mobius default is also darker and has the same color shift on that building.

The MadVR screenshot should be ignored. It has been shown to me elsewhere, that a filter is being added to make the picture brighter and isn't a result of tone-mapping. If you look at it, there is a general color desaturation. I'm not overly fond of that.

It does seem to me that mpv's white point is a little off the mark.

@Doofussy2
Copy link

Doofussy2 commented Jan 20, 2021

That's a great movie btw. If you understand the 2nd law of thermodynamics/entropy, you'll have a deeper appreciation for it.

@laichiaheng
Copy link
Author

laichiaheng commented Jan 20, 2021

@Doofussy2 If bt.2390 were tunable, would it look better than this?
I only saw some description of entropy on the internet or somebody talked about it, I don't really know what it actually is in physics or math.

@Doofussy2
Copy link

Doofussy2 commented Jan 20, 2021

@Doofussy2 If bt.2390 were tunable, would it look better than this?

That would depend on how it was implemented. @haasn would have to work some magic. But I think a few tweaks to the current implementation would probably be more achievable.

I only saw some description of entropy on the internet or somebody talked about it, I don't really know what it actually is in physics or maths.

Just look up 2nd law of thermodynamics.

@laichiaheng
Copy link
Author

laichiaheng commented Jan 20, 2021

@Doofussy2 If bt.2390 were tunable, would it look better than this?

That would depend on how it was implemented. @haasn would have to work some magic. But I think a few tweaks to the current implementation would probably be more achievable.

I only saw some description of entropy on the internet or somebody talked about it, I don't really know what it actually is in physics or math.

Just look up 2nd law of thermodynamics.

I was amazed that he could put a reverse thing in the same scene at the same time, and it makes sense.

@Doofussy2
Copy link

Reverse entropy is a complicated topic for a movie. Many people won't understand what they're seeing.

@hooke007
Copy link
Contributor

Individually, I see that tone-mapping Gamma looks better in the night scenes, while 2390 seems always show the correct (or natural?) hue in the day scenes.

2390
d hcp 2390

gamma
d hcp gamma 1 8

2390
n hcp 2390

gamma
n hcp gamma 1 8

@Akemi
Copy link
Member

Akemi commented Apr 29, 2021

since we have an issue open for this and the actual question has been discussed. i will close this one.

@Akemi Akemi closed this as completed Apr 29, 2021
@ojab
Copy link

ojab commented Apr 29, 2021

I suppose an issue is the #7984?

@Akemi
Copy link
Member

Akemi commented Apr 29, 2021

yeah. i also think it can possibly related to some other open issues labeled with core:color-management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants
@wiiaboo @ojab @Akemi @avih @laichiaheng @Doofussy2 @hooke007 and others