demux_lavf: return AVERROR_EOF on file end #5033
Closed
Conversation
Signed-off-by: Daniel Kucera <daniel.kucera@gmail.com>
|
Appreciated (though still mismatches the coding style, maybe use a ?: expression), but FFmpeg is probably still broken since it broke the API for this. Older mpv releases will not work. |
Earnestly
referenced
this pull request
Oct 28, 2017
This is required now. Can't have FFmpeg upstream randomly break us and then not fix it (like this recent EOF issue). Upstream FFmpeg is of course still supported, but you will need to edit the build scripts. Official support is only with the master branch of our own repo.
|
Seems like FFmpeg finally fixed their API break. Merged this PR as e9dc4ac. I changed the logic and the style of the added code. |
ghost
closed this
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
libavformat fixed bug when 0 was considered as EOF. Now we need to return proper EOF using AVERROR_EOF
Signed-off-by: Daniel Kucera daniel.kucera@gmail.com