New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Kammerl Beat Repeat to Parasites #1

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@boourns

boourns commented Aug 18, 2017

This just ports Julius's beat repeat code into Parasites. I generated a patch based on the last two commits of this fork https://github.com/jkammerl/eurorack/commits/master

There is no size problem as far as I can tell. It compiles and uploads fine, all modes play, buffer saving/restoring works fine.

There's a bit of work I still need to do - reverb is still enabled on the beat-repeat algorithm, and I want to go through the patch one more time to ensure that I didn't miss anything else. It could use some people testing it too to ensure it performs the same as the isolated firmware.

I haven't played with the spectral clouds algorithm much - would it be worth also implementing that as an additional algorithm, or replacing spectral mode, or leave it be?

@boourns

This comment has been minimized.

Show comment
Hide comment
@boourns

boourns Aug 25, 2017

@mqtthiqs @jkammerl hi guys

if I polish this up are you cool with merging it, or do you want to keep these firmwares separate?

boourns commented Aug 25, 2017

@mqtthiqs @jkammerl hi guys

if I polish this up are you cool with merging it, or do you want to keep these firmwares separate?

@unity2k

This comment has been minimized.

Show comment
Hide comment
@unity2k

unity2k Aug 25, 2017

My hope is that @mqtthiqs and @jkammerl would also like to see the merger. I'd also like to vote in the affirmative for Spectral Clouds to be included.

unity2k commented Aug 25, 2017

My hope is that @mqtthiqs and @jkammerl would also like to see the merger. I'd also like to vote in the affirmative for Spectral Clouds to be included.

@mqtthiqs

This comment has been minimized.

Show comment
Hide comment
@mqtthiqs

mqtthiqs Aug 26, 2017

Owner

Hi there, thanks for your work @boourns. I'm really happy that someone is still improving this, and kammerl's modes look really interesting. That said, I'd rather have this development not take place in my repository: I am not maintaining this project anymore and I don't want to be held responsible for the changes, releases, bug fixes etc. Feel free to clone and advertise you own repository with the merge though!

Owner

mqtthiqs commented Aug 26, 2017

Hi there, thanks for your work @boourns. I'm really happy that someone is still improving this, and kammerl's modes look really interesting. That said, I'd rather have this development not take place in my repository: I am not maintaining this project anymore and I don't want to be held responsible for the changes, releases, bug fixes etc. Feel free to clone and advertise you own repository with the merge though!

@boourns

This comment has been minimized.

Show comment
Hide comment
@boourns

boourns Aug 28, 2017

OK, thanks @mqtthiqs!

I'll close this here and figure out my next steps. Cheers.

boourns commented Aug 28, 2017

OK, thanks @mqtthiqs!

I'll close this here and figure out my next steps. Cheers.

@boourns boourns closed this Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment