From 380f286d46f1c3d7a64c7bd851bbe8d84b797074 Mon Sep 17 00:00:00 2001 From: Daniel Lando Date: Wed, 10 Apr 2024 10:51:16 +0200 Subject: [PATCH] fix(browser): uncaught error when stream is destroyed with error Fixes #1839 --- src/lib/BufferedDuplex.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/BufferedDuplex.ts b/src/lib/BufferedDuplex.ts index 590e2c615..520f9142f 100644 --- a/src/lib/BufferedDuplex.ts +++ b/src/lib/BufferedDuplex.ts @@ -79,7 +79,8 @@ export class BufferedDuplex extends Duplex { _destroy(err: Error, callback: (error: Error) => void): void { this.writeQueue = [] - this.proxy.destroy(err) + // do not pass error here otherwise we should listen for `error` event on proxy to prevent uncaught exception + this.proxy.destroy() callback(err) }