From 56e6e23c0fb775bfd16edf04d6b28f6bbcf05023 Mon Sep 17 00:00:00 2001
From: Daniel Lando <daniel.sorridi@gmail.com>
Date: Wed, 24 Jan 2024 11:13:37 +0100
Subject: [PATCH] fix: emit `error` event on connack timeout (#1781)

* fix: emit `error` event on connack timeout

* fix: force close client
---
 src/lib/client.ts       |  1 +
 test/abstract_client.ts | 12 ++++++++++++
 2 files changed, 13 insertions(+)

diff --git a/src/lib/client.ts b/src/lib/client.ts
index f7a9b4dcc..2378e0fd6 100644
--- a/src/lib/client.ts
+++ b/src/lib/client.ts
@@ -850,6 +850,7 @@ export default class MqttClient extends TypedEventEmitter<MqttClientEventCallbac
 			this.log(
 				'!!connectTimeout hit!! Calling _cleanUp with force `true`',
 			)
+			this.emit('error', new Error('connack timeout'))
 			this._cleanUp(true)
 		}, this.options.connectTimeout)
 
diff --git a/test/abstract_client.ts b/test/abstract_client.ts
index d51063548..c7daa1bc6 100644
--- a/test/abstract_client.ts
+++ b/test/abstract_client.ts
@@ -3004,6 +3004,18 @@ export default function abstractTest(server, config, ports) {
 			}, 50)
 		})
 
+		it('should emit connack timeout error', function _test(t, done) {
+			const client = connect({
+				connectTimeout: 0,
+				reconnectPeriod: 5000,
+			})
+
+			client.on('error', (err) => {
+				assert.equal(err.message, 'connack timeout')
+				client.end(true, done)
+			})
+		})
+
 		it(
 			'should resend in-flight QoS 1 publish messages from the client',
 			{