New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase moo on master, fix things, merge to master. #50

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dams

dams commented Apr 26, 2016

As discussed per email, this is a CPANPR challenge PR. I basically only rebase, fixed stuff, until local tests pass. feedback welcome

@mrallen1

This comment has been minimized.

Show comment
Hide comment
@mrallen1

mrallen1 Apr 27, 2016

Owner

Considering moving the prereq to Moo 2. Thoughts on that? I don't have a lot of direct experience with it, but I like that the new strictures module has selected warnings non-fatalized.

Owner

mrallen1 commented Apr 27, 2016

Considering moving the prereq to Moo 2. Thoughts on that? I don't have a lot of direct experience with it, but I like that the new strictures module has selected warnings non-fatalized.

@mrallen1

This comment has been minimized.

Show comment
Hide comment
@mrallen1

mrallen1 Apr 27, 2016

Owner

Also - thank you so much 🍬 Really appreciate you stepping in to do this.

Owner

mrallen1 commented Apr 27, 2016

Also - thank you so much 🍬 Really appreciate you stepping in to do this.

@dams

This comment has been minimized.

Show comment
Hide comment
@dams

dams Apr 27, 2016

No problem. So yes you either want Moo 2 or at least use Moo::Lax that I wrote because of the stricture craziness... But yes Moo2 is good, no issues or backward compat problem, so I recommend depending on it.

dams commented Apr 27, 2016

No problem. So yes you either want Moo 2 or at least use Moo::Lax that I wrote because of the stricture craziness... But yes Moo2 is good, no issues or backward compat problem, so I recommend depending on it.

@mrallen1

This comment has been minimized.

Show comment
Hide comment
@mrallen1

mrallen1 Apr 28, 2016

Owner

Yeah I think Moo 2 is the way to go. Moo 1 fatalizes too aggressively which is why I switched to Moo::Lax for many other of my projects. I ought to switch back to Moo 2 on those some day :)

Owner

mrallen1 commented Apr 28, 2016

Yeah I think Moo 2 is the way to go. Moo 1 fatalizes too aggressively which is why I switched to Moo::Lax for many other of my projects. I ought to switch back to Moo 2 on those some day :)

@mrallen1

This comment has been minimized.

Show comment
Hide comment
@mrallen1

mrallen1 Nov 30, 2017

Owner

Thank you so much for this PR! I appreciate the time and effort you spent on it even though I can't or maybe shouldn't merge it.

Owner

mrallen1 commented Nov 30, 2017

Thank you so much for this PR! I appreciate the time and effort you spent on it even though I can't or maybe shouldn't merge it.

@mrallen1 mrallen1 closed this Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment